2 messages, 2 authors, 2021-11-30 · open the first message on its own page
From: Junio C Hamano <hidden>
Date: 2021-11-30 06:47:31
"Elijah Newren via GitGitGadget" [off-list ref] writes:
+ # Although we want pwd & git status to pass, test for existing + # rather than desired behavior. + if test "$works" == "success"
Don't double "=" here. We are not writing for bash. There are a few more instances of the same mistake in this patch.
From: Elijah Newren <hidden>
Date: 2021-11-30 06:53:24
On Mon, Nov 29, 2021 at 10:47 PM Junio C Hamano [off-list ref] wrote:
"Elijah Newren via GitGitGadget" [off-list ref] writes:quoted
+ # Although we want pwd & git status to pass, test for existing + # rather than desired behavior. + if test "$works" == "success"Don't double "=" here. We are not writing for bash. There are a few more instances of the same mistake in this patch.
Yep, also pointed out by Eric. I've got a v5 queued up whose change is just fixing this, but I'm waiting a bit to see if other items are spotted in review before sending. Thanks for spotting.