"format-patch" command doesn't support SSH signing

3 messages, 3 authors, 2021-11-23 · open the first message on its own page

"format-patch" command doesn't support SSH signing

From: Marcos Alano <hidden>
Date: 2021-11-23 13:04:32

Hello,

I was trying to generate a patch to send to a project (Linux 
specifically) but when I generate the patch using "format-patch" I saw 
there was no "Signed-Off" line, but my commit is signed using SSH. My 
git version is the latest, 2.34.

Thank you.

Re: "format-patch" command doesn't support SSH signing

From: Ævar Arnfjörð Bjarmason <hidden>
Date: 2021-11-23 16:03:30

On Tue, Nov 23 2021, Marcos Alano wrote:
Hello,

I was trying to generate a patch to send to a project (Linux
specifically) but when I generate the patch using "format-patch" I saw 
there was no "Signed-Off" line, but my commit is signed using SSH. My
git version is the latest, 2.34.
The Signed-off-by in commit messages doesn't have anything to do with
SSH, GPG etc. signing, it's just a way of signaling that you're the
author of the change, and/or can certify it as being includable in the
project for authorship & copyright reasons. It's mostly used in
linux.git and git.git, see a "git grep Signed-off-by" in those for more
details.

Re: "format-patch" command doesn't support SSH signing

From: Johannes Schindelin <hidden>
Date: 2021-11-23 16:14:32

Hi Marcos,

On Tue, 23 Nov 2021, Marcos Alano wrote:
I was trying to generate a patch to send to a project (Linux specifically) but
when I generate the patch using "format-patch" I saw there was no "Signed-Off"
line, but my commit is signed using SSH. My git version is the latest, 2.34.
A "Sign-off" is a convention for the commit message, but _signing a
commit_ is a cryptographic signature. They are two different things.

You can add the "Signed-off-by:" trailers via `git format-patch`'s
`--signoff` option:
https://git-scm.com/docs/git-format-patch#Documentation/git-format-patch.txt---signoff

Ciao,
Johannes
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help