[PATCH] Doc: no midx and partial clone relation

Subsystems: documentation, the rest

STALE1727d

2 messages, 2 authors, 2021-11-22 · open the first message on its own page

[PATCH] Doc: no midx and partial clone relation

From: Jonathan Tan <hidden>
Date: 2021-11-22 18:41:22

The multi-pack index treats promisor packfiles (that is, packfiles that
have an accompanying .promisor file) the same as other packfiles. Remove
a section in the documentation that seems to indicate otherwise.

Signed-off-by: Jonathan Tan <redacted>
---
Stolee, can you check if my understanding is correct?

To my recollection, midx does not treat promisor packfiles specially,
and searching for "promisor" in midx.c seems to support that (the only
results are relating to selection of commits for midx bitmap creation).
---
 Documentation/technical/multi-pack-index.txt | 5 -----
 1 file changed, 5 deletions(-)
diff --git a/Documentation/technical/multi-pack-index.txt b/Documentation/technical/multi-pack-index.txt
index 86f40f2490..fc213cd1e6 100644
--- a/Documentation/technical/multi-pack-index.txt
+++ b/Documentation/technical/multi-pack-index.txt
@@ -87,11 +87,6 @@ Future Work
   helpful to organize packfiles by object type (commit, tree, blob,
   etc.) and use this metadata to help that maintenance.
 
-- The partial clone feature records special "promisor" packs that
-  may point to objects that are not stored locally, but available
-  on request to a server. The multi-pack-index does not currently
-  track these promisor packs.
-
 Related Links
 -------------
 [0] https://bugs.chromium.org/p/git/issues/detail?id=6
-- 
2.34.0.rc2.393.gf8c9666880-goog

Re: [PATCH] Doc: no midx and partial clone relation

From: Derrick Stolee <hidden>
Date: 2021-11-22 19:29:48

On 11/22/2021 1:41 PM, Jonathan Tan wrote:
The multi-pack index treats promisor packfiles (that is, packfiles that
have an accompanying .promisor file) the same as other packfiles. Remove
a section in the documentation that seems to indicate otherwise.

Signed-off-by: Jonathan Tan <redacted>
---
Stolee, can you check if my understanding is correct?

To my recollection, midx does not treat promisor packfiles specially,
and searching for "promisor" in midx.c seems to support that (the only
results are relating to selection of commits for midx bitmap creation).
Yes, you are correct that the promisor packfiles are included in
the multi-pack-index.
-- The partial clone feature records special "promisor" packs that
-  may point to objects that are not stored locally, but available
-  on request to a server. The multi-pack-index does not currently
-  track these promisor packs.
-
The intention of this paragraph was probably that the multi-pack-index
file does not track the properties of a pack-file such as whether a
.promisor or .keep file exists. I think one thought was to eventually
let the multi-pack-index track those properties, but there wasn't much
value in it.

Deleting this paragraph is a suitable clarification.

Thanks,
-Stolee
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help