Re: [PATCH 0/2] am: support --always option to am empty commits

3 messages, 3 authors, 2021-11-12 · open the first message on its own page

Re: [PATCH 0/2] am: support --always option to am empty commits

From: Junio C Hamano <hidden>
Date: 2021-11-12 06:47:20

René Scharfe [off-list ref] writes:
Am 12.11.21 um 05:58 schrieb Aleen via GitGitGadget:
quoted
Since that git has supported the --always option for the git-format-patch
command to create a patch with empty commit message, git-am should support
applying and committing with empty patches.
The symmetry is compelling, but "always" is quite generic.  I can see
e.g. someone expecting "git am --always" to imply --keep-non-patch.
What symmetry?
git commit and cherry-pick have --allow-empty, which is (a bit) more
specific.  That seems to me a better option name to copy for a commit-
creating command like git am.
That one I can believe, even though I do not necessarily think it is
a good idea to add such an option.

Re: [PATCH 0/2] am: support --always option to am empty commits

From: Aleen 徐沛文 <hidden>
Date: 2021-11-12 07:17:13

Dears Junio C Hamano:
René Scharfe [off-list ref] writes:
quoted
Am 12.11.21 um 05:58 schrieb Aleen via GitGitGadget:
quoted
Since that git has supported the --always option for the git-format-patch
command to create a patch with empty commit message, git-am should support
applying and committing with empty patches.
The symmetry is compelling, but "always" is quite generic.  I can see
e.g. someone expecting "git am --always" to imply --keep-non-patch.
What symmetry?
quoted
git commit and cherry-pick have --allow-empty, which is (a bit) more
specific.  That seems to me a better option name to copy for a commit-
creating command like git am.
That one I can believe, even though I do not necessarily think it is
a good idea to add such an option.
In some cases when we need to migrate commits from one branch to another branch,
from one repo to another repo, it should be necessary.

Aleen

Re: [PATCH 0/2] am: support --always option to am empty commits

From: René Scharfe <hidden>
Date: 2021-11-12 15:28:41

Am 12.11.21 um 07:47 schrieb Junio C Hamano:
René Scharfe [off-list ref] writes:
quoted
Am 12.11.21 um 05:58 schrieb Aleen via GitGitGadget:
quoted
Since that git has supported the --always option for the git-format-patch
command to create a patch with empty commit message, git-am should support
applying and committing with empty patches.
The symmetry is compelling, but "always" is quite generic.  I can see
e.g. someone expecting "git am --always" to imply --keep-non-patch.
What symmetry?
To have the same option in both producer and consumer.

René
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help