Jeff King [off-list ref] writes:
I'm happy enough with it. I don't know what the plan is for the -rc
period, though. AFAICT the bug is in v2.33.1, so it's not technically a
v2.34-rc problem. It could wait for the next maint release.
Hmph, if it was in v2.33.0 then it is not, but if it was introduced
between v2.33.0 and v2.33.1, then it is a problem for the current
cycle, no?
On Wed, Nov 03, 2021 at 10:44:11AM -0700, Junio C Hamano wrote:
Jeff King [off-list ref] writes:
quoted
I'm happy enough with it. I don't know what the plan is for the -rc
period, though. AFAICT the bug is in v2.33.1, so it's not technically a
v2.34-rc problem. It could wait for the next maint release.
Hmph, if it was in v2.33.0 then it is not, but if it was introduced
between v2.33.0 and v2.33.1, then it is a problem for the current
cycle, no?
I guess it depends how you consider the cycle. It's in v2.33.1 but not
v2.33.0, so yes, anybody going from v2.33.0 to v2.34.0 will see it as a
regression. I don't have any problem with fixing it for v2.34.0, and I
think the fix Phillip provided is minimally invasive. I just didn't
consider it quite the same as a bug that had never been in a released
version at all (and I know you are often hesitant to throw too much into
the -rc part of the cycle).
-Peff