Re: [PATCH v3 0/8] Allow clean/smudge filters to handle huge files in the LLP64 data model

[Re-sending, as it seems that the Git mailing list is causing trouble
again, at least I do not see this on lore.kernel.org/git]


On Fri, 29 Oct 2021, Johannes Schindelin wrote:

Hi Junio,

On Fri, 29 Oct 2021, Junio C Hamano wrote:

quoted

"Johannes Schindelin via GitGitGadget" [off-list ref]
writes:

quoted

This patch series came in via the Git for Windows fork
[https://github.com/git-for-windows/git/pull/3487], and I intend to merge it
before v2.34.0-rc0, therefore I appreciate every careful review you gentle
people can spare.

It is way too late for my tree to go in before -rc0, but the patches
in the last round, with the "Changes since v2" description below,
all sound sensible, including the decision to stop here, instead of
doing "everything should be either size_t or intmax_t" conversion.

Thank you for your careful review, it definitely helped with polishing the
patches.

quoted

7/8 did not apply for me to the tip of 'master', but "am -3" wiggled
it in.  You may want to double check the results.

Right, I purposefully based the patches on v2.32.0 so they would merge
cleanly into Git for Windows' `main` branch.

I should have clarified that I was talking about merging that PR into Git
for Windows before the -rc0 ;-)

Speaking of which, -rc0 is still coming, right? ;-)
https://tinyurl.com/gitcal still claims that it was scheduled for
yesterday.

quoted

As the primary author of the series, given the cover title matches the
title of one step in the series, seems to be Matt, let me queue them
under mc/clean-smudge-with-llp64 topic.

Absolutely. Matt was in the driving seat, I was just reviewing and helping
here and there, and then shepherding the patch series upstream. It was my
decision to start upstreaming before merging it into Git for Windows, but
the plan was all along to get this into Git for Windows v2.34.0 because
there are Git LFS users using Windows who are eagerly awaiting this fix.

I am not aware of any other popular platform using the LLP64 data model,
therefore I do not even think that these patches have to be fast-tracked
into Git v2.34.0, next cycle would be good enough. Unless you are aware of
other such platforms that do not rely on the Git for Windows fork, but on
Git built from your repository?

Ciao,
Dscho

On 29/10/2021 22:12, Johannes Schindelin wrote:

I am not aware of any other popular platform using the LLP64 data model,
therefore I do not even think that these patches have to be fast-tracked
into Git v2.34.0, next cycle would be good enough. Unless you are aware of
other such platforms that do not rely on the Git for Windows fork, but on
Git built from your repository?

I was under the impression that the original Raspberry Pi also used the
LLP64 model, or similar, and that had started of Torsten (tboegi) on the
extensive early work on this. I was just looking at the zlib parts
following the Git Merge.

Torsten was compiling for Rasbian (gcc (Raspbian 6.3.0-18+rpi1+deb9u1)
6.3.0 20170516)

Philip

On Sat, Oct 30, 2021 at 04:16:31PM +0100, Philip Oakley wrote:

On 29/10/2021 22:12, Johannes Schindelin wrote:

quoted

I am not aware of any other popular platform using the LLP64 data model,
therefore I do not even think that these patches have to be fast-tracked
into Git v2.34.0, next cycle would be good enough. Unless you are aware of
other such platforms that do not rely on the Git for Windows fork, but on
Git built from your repository?

I was under the impression that the original Raspberry Pi also used the
LLP64 model, or similar, and that had started of Torsten (tboegi) on the
extensive early work on this. I was just looking at the zlib parts
following the Git Merge.

Torsten was compiling for Rasbian (gcc (Raspbian 6.3.0-18+rpi1+deb9u1)
6.3.0 20170516)

Philip

The raspi does not use LLP64.
However, the gcc from above did warn about a long - size_t mixup.
Even if both are 32 bit.

Hi Torsten,
On 30/10/2021 18:35, Torsten Bögershausen wrote:

On Sat, Oct 30, 2021 at 04:16:31PM +0100, Philip Oakley wrote:

quoted

On 29/10/2021 22:12, Johannes Schindelin wrote:

quoted

I am not aware of any other popular platform using the LLP64 data model,
therefore I do not even think that these patches have to be fast-tracked
into Git v2.34.0, next cycle would be good enough. Unless you are aware of
other such platforms that do not rely on the Git for Windows fork, but on
Git built from your repository?

I was under the impression that the original Raspberry Pi also used the
LLP64 model, or similar, and that had started of Torsten (tboegi) on the
extensive early work on this. I was just looking at the zlib parts
following the Git Merge.

Torsten was compiling for Rasbian (gcc (Raspbian 6.3.0-18+rpi1+deb9u1)
6.3.0 20170516)

Philip

The raspi does not use LLP64.
However, the gcc from above did warn about a long - size_t mixup.
Even if both are 32 bit.

Thanks for the clarification. Looks like I'd misinterpreted what you'd
said at the time.
--
Philip