# Re: \[PATCH v4 8/8\] progress.c: add \& assert a "global\_progress" variable

- From: Johannes Sixt \<hidden\>
- Date: 2021-10-25 11:53:50 
- List: git
- Page: https://ratatoskr.run/git/2021/10/7909585
- Thread: https://ratatoskr.run/git/2021/06/7892958/t/3.md

```text
Am 25.10.21 um 13:25 schrieb Ævar Arnfjörð Bjarmason:
> Once we have a
> global current progress object we'll be able to update that object via
> SIGALRM, this will cover cases where we're busy, but either haven't
> invoked our first display_progress() yet, or the time between
> display_progress() is too long. See [3] for early code to do that.

This can't be a goal. You cannot do serious stuff in a signal handler.
Don't proliferate complicated signal handlers.

On top of that, our SIGALRM handler on Windows runs in its own thread
and can't do more than set a volatile sigatomic_t (and even that is
undefined behavior, strictly speaking).

-- Hannes
```