Re: [PATCH v5 3/3] send-email docs: add format-patch options

2 messages, 2 authors, 2021-09-25 · open the first message on its own page

Re: [PATCH v5 3/3] send-email docs: add format-patch options

From: Junio C Hamano <hidden>
Date: 2021-09-25 04:07:41

Bagas Sanjaya [off-list ref] writes:
On 25/09/21 03.03, Junio C Hamano wrote:
quoted
Ah, thanks for explanation.
     git format-patch -2
would be options-only way to "indicate some sort of revision", so
perhaps
     . git send-email <send-email options> files|directory
     . git send-email <send-email options> <format-patch options>
(where "options" is used to refer to both --options and arguments)
would illustrate the differences better?
But we can also directly specify revision range (commonly <common
ancestor>..HEAD or HEAD ^<common ancestor>).
That is exactly why I have the parenthetical definition of what
"options" mean in my explanation.  

	git format-patch -2
	git format-patch master
	git format-patch master..HEAD

Everything after "git format-patch", i.e. -2, master, master..HEAD,
are usable, and there isn't much point in singling out revision
ranges.  FWIW, I think you can even give "-- <pathspec>" at the end,
which are not options or revision ranges.

Re: [PATCH v5 3/3] send-email docs: add format-patch options

From: Carlo Marcelo Arenas Belón <hidden>
Date: 2021-09-25 06:13:32

On Fri, Sep 24, 2021 at 09:07:35PM -0700, Junio C Hamano wrote:
Bagas Sanjaya [off-list ref] writes:
quoted
On 25/09/21 03.03, Junio C Hamano wrote:
quoted
Ah, thanks for explanation.
     git format-patch -2
would be options-only way to "indicate some sort of revision", so
perhaps
     . git send-email <send-email options> files|directory
     . git send-email <send-email options> <format-patch options>
(where "options" is used to refer to both --options and arguments)
would illustrate the differences better?
But we can also directly specify revision range (commonly <common
ancestor>..HEAD or HEAD ^<common ancestor>).
That is exactly why I have the parenthetical definition of what
"options" mean in my explanation.  

	git format-patch -2
	git format-patch master
	git format-patch master..HEAD

Everything after "git format-patch", i.e. -2, master, master..HEAD,
are usable, and there isn't much point in singling out revision
ranges.  FWIW, I think you can even give "-- <pathspec>" at the end,
which are not options or revision ranges.
<format-patch options> then it is; would the following be worth adding
in top so the recursive reference can be followed?

Carlo
------ >8 ------
diff --git a/Documentation/git-format-patch.txt b/Documentation/git-format-patch.txt
index fe2f69d36e..806ff93259 100644
--- a/Documentation/git-format-patch.txt
+++ b/Documentation/git-format-patch.txt
@@ -30,7 +30,7 @@ SYNOPSIS
 		   [--range-diff=<previous> [--creation-factor=<percent>]]
 		   [--filename-max-length=<n>]
 		   [--progress]
-		   [<common diff options>]
+		   [<common diff options>] [<rev-list options>]
 		   [ <since> | <revision range> ]
 
 DESCRIPTION
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help