[PATCH] rev-parse: fix mismatch quoting of separator in the message

Subsystems: the rest

STALE1808d

2 messages, 2 authors, 2021-09-22 · open the first message on its own page

[PATCH] rev-parse: fix mismatch quoting of separator in the message

From: Bagas Sanjaya <hidden>
Date: 2021-09-22 11:18:11

There is a quoting mismatch quoting `--` separator in "no usage string
given...." message (`' instead of ``). Fix it.

Signed-off-by: Bagas Sanjaya <redacted>
---
 builtin/rev-parse.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/builtin/rev-parse.c b/builtin/rev-parse.c
index 22c4e1a4ff..a35dbad6c4 100644
--- a/builtin/rev-parse.c
+++ b/builtin/rev-parse.c
@@ -439,7 +439,7 @@ static int cmd_parseopt(int argc, const char **argv, const char *prefix)
 		ALLOC_GROW(usage, unb + 1, usz);
 		if (!strcmp("--", sb.buf)) {
 			if (unb < 1)
-				die(_("no usage string given before the `--' separator"));
+				die(_("no usage string given before the `--` separator"));
 			usage[unb] = NULL;
 			break;
 		}
base-commit: 99c99ed8259bf070cd8ae7b51a94904b7cf5c161
-- 
2.25.1

Re: [PATCH] rev-parse: fix mismatch quoting of separator in the message

From: Taylor Blau <hidden>
Date: 2021-09-22 17:40:59

On Wed, Sep 22, 2021 at 06:17:45PM +0700, Bagas Sanjaya wrote:
There is a quoting mismatch quoting `--` separator in "no usage string
given...." message (`' instead of ``). Fix it.
For what it's worth, I think that the `' style is typographic, since the
pair look like English "smart quotes" (as opposed to straight quotes). I
have no opinion about which is better, but I don't think the pre-image
was necessarily a mistake.

Thanks,
Taylor
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help