Re: [PATCH v2 1/1] submodule--helper: fix incorrect newlines in an error message

Kaartic Sivaraam [off-list ref] writes:

A refactoring[1] done as part of the recent conversion of
'git submodule add' to builtin, changed the error message
shown when a Git directory already exists locally for a submodule
name. Before the refactoring, the error used to appear like so:
...
As one could observe the remote information is printed along with the
first line rather than on its own line. Also, there's an additional
newline following output.

Make the error message consistent with the error message that used to be
printed before the refactoring.

Makes sense.  Atharva, an ack?

Junio C Hamano [off-list ref] writes:

Kaartic Sivaraam [off-list ref] writes:

quoted

A refactoring[1] done as part of the recent conversion of
'git submodule add' to builtin, changed the error message
shown when a Git directory already exists locally for a submodule
name. Before the refactoring, the error used to appear like so:
...
As one could observe the remote information is printed along with the
first line rather than on its own line. Also, there's an additional
newline following output.

Make the error message consistent with the error message that used to be
printed before the refactoring.

Makes sense.  Atharva, an ack?

Sorry for the delay in looking into this, I just left a comment. After
that minor nit is addressed, it's an ack for me :-)