Re: [PATCH 1/5] fsmonitor: enhance existing comments

2 messages, 2 authors, 2021-09-23 · open the first message on its own page

Re: [PATCH 1/5] fsmonitor: enhance existing comments

From: Junio C Hamano <hidden>
Date: 2021-09-17 06:44:26

Bagas Sanjaya [off-list ref] writes:
On 17/09/21 02.54, Jeff Hostetler via GitGitGadget wrote:
quoted
-		/* If we're going to check every file, ensure we save the results */
+		/*
+		 * If we're going to check every file, ensure we save
+		 * the results.
+		 */
Why did you split the comment above?
I would guess that the reason why it is done is because the original
line is overly long it (extends to 84 columns, if I am counting
correctly).

Re: [PATCH 1/5] fsmonitor: enhance existing comments

From: Jeff Hostetler <hidden>
Date: 2021-09-23 14:11:36


On 9/17/21 2:44 AM, Junio C Hamano wrote:
Bagas Sanjaya [off-list ref] writes:
quoted
On 17/09/21 02.54, Jeff Hostetler via GitGitGadget wrote:
quoted
-		/* If we're going to check every file, ensure we save the results */
+		/*
+		 * If we're going to check every file, ensure we save
+		 * the results.
+		 */
Why did you split the comment above?
I would guess that the reason why it is done is because the original
line is overly long it (extends to 84 columns, if I am counting
correctly).
Yes, I just wrapped it because it was too long and the commit
was focused on improving other nearby comments (and no code),
so it seemed like a good opportunity to cleanup this one too.

Jeff
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help