# Re: \[PATCH\] test: fix for COLUMNS and bash 5

- From: Junio C Hamano \<hidden\>
- Date: 2021-08-23 20:24:24 
- List: git
- Page: https://ratatoskr.run/git/2021/08/7900060
- Thread: https://ratatoskr.run/git/2021/08/7900060/t.md

```text
Ævar Arnfjörð Bjarmason [ref] writes:

> Now that we're post-release are you interested in a re-roll of
> https://lore.kernel.org/git/cover-v3-0.3-00000000000-20210804T230335Z-avarab@gmail.com/
> + removal of the bash-specific checkwinsize added here, or would you

Let's wait until we see a concrete breakage report that shows that
checkwinsize is insufficient.  Even if such a second shell calls its
facility differently, as long as it works in a similar way and
another single liner like

    test -n "$BASH_VERSION" && shopt -u checkwinsize 2>/dev/null

we can keep piling such a single-liner next to each other, as the
number of shells we need to cater to would be less than a handful
anyway.

Thanks.
```