[PATCH] fixup! fsmonitor-fs-listen-macos: implement FSEvent listener on MacOS

Subsystems: the rest

STALE1810d

2 messages, 2 authors, 2021-08-19 · open the first message on its own page

[PATCH] fixup! fsmonitor-fs-listen-macos: implement FSEvent listener on MacOS

From: Carlo Marcelo Arenas Belón <hidden>
Date: 2021-08-19 18:37:26

clang defines __GNUC__ for compatibility with gcc (indeed it misrepresents
itself as gcc 4.2.1), so instead use the __clang__ specific macro to
distinguish between them.

tested with Apple clang 12.0.5, clang 14 and gcc 11.2.0

Signed-off-by: Carlo Marcelo Arenas Belón <redacted>
---
 compat/fsmonitor/fsmonitor-fs-listen-macos.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/compat/fsmonitor/fsmonitor-fs-listen-macos.c b/compat/fsmonitor/fsmonitor-fs-listen-macos.c
index 02f89de216..c55ec35b5d 100644
--- a/compat/fsmonitor/fsmonitor-fs-listen-macos.c
+++ b/compat/fsmonitor/fsmonitor-fs-listen-macos.c
@@ -1,4 +1,4 @@
-#if defined(__GNUC__)
+#ifndef __clang__
 /*
  * It is possible to #include CoreFoundation/CoreFoundation.h when compiling
  * with clang, but not with GCC as of time of writing.
-- 
2.33.0.481.g26d3bed244

Re: [PATCH] fixup! fsmonitor-fs-listen-macos: implement FSEvent listener on MacOS

From: Jeff Hostetler <hidden>
Date: 2021-08-19 20:49:05


On 8/19/21 2:36 PM, Carlo Marcelo Arenas Belón wrote:
quoted hunk
clang defines __GNUC__ for compatibility with gcc (indeed it misrepresents
itself as gcc 4.2.1), so instead use the __clang__ specific macro to
distinguish between them.

tested with Apple clang 12.0.5, clang 14 and gcc 11.2.0

Signed-off-by: Carlo Marcelo Arenas Belón <redacted>
---
  compat/fsmonitor/fsmonitor-fs-listen-macos.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/compat/fsmonitor/fsmonitor-fs-listen-macos.c b/compat/fsmonitor/fsmonitor-fs-listen-macos.c
index 02f89de216..c55ec35b5d 100644
--- a/compat/fsmonitor/fsmonitor-fs-listen-macos.c
+++ b/compat/fsmonitor/fsmonitor-fs-listen-macos.c
@@ -1,4 +1,4 @@
-#if defined(__GNUC__)
+#ifndef __clang__
  /*
   * It is possible to #include CoreFoundation/CoreFoundation.h when compiling
   * with clang, but not with GCC as of time of writing.
thanks!
Jeff
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help