Re: [PATCH v5] clone: set submodule.recurse=true if user enables feature.experimental flag

3 messages, 3 authors, 2021-08-13 · open the first message on its own page

Re: [PATCH v5] clone: set submodule.recurse=true if user enables feature.experimental flag

From: Junio C Hamano <hidden>
Date: 2021-08-13 20:30:27

Emily Shaffer [off-list ref] writes:
I think the right move, then, is to explore whether your suggestion in
https://lore.kernel.org/git/xmqqeeaxw28z.fsf%40gitster.g is appropriate
- I have the sense that it is, but I want to make sure to think it
through before I say so for sure. 
Not that one---it was a 40% tongue-in-cheek comment, and does not
deserve to be called a suggestion.  

Re: [PATCH v5] clone: set submodule.recurse=true if user enables feature.experimental flag

From: Emily Shaffer <hidden>
Date: 2021-08-13 20:39:00

On Fri, Aug 13, 2021 at 01:30:22PM -0700, Junio C Hamano wrote:
Emily Shaffer [off-list ref] writes:
quoted
I think the right move, then, is to explore whether your suggestion in
https://lore.kernel.org/git/xmqqeeaxw28z.fsf%40gitster.g is appropriate
- I have the sense that it is, but I want to make sure to think it
through before I say so for sure. 
Not that one---it was a 40% tongue-in-cheek comment, and does not
deserve to be called a suggestion.  
Ah well ;)

Anyway, I think it does not make sense, as behavior starts to change for
people who already cloned expecting not to recurse (Jonathan N says this
is the case for his Rust checkout, for example) - and apparently
'submodule.recurse=true' has some weird edge cases for commands which
are happy to run out-of-repo.

Mahi mentioned wanting to rework her commit to use a config besides
'feature.experimental' for this same behavior, so hopefully we will see
that change come through soon - but today is also the last day of her
internship, so we may not be so lucky.

 - Emily

Re: [PATCH v5] clone: set submodule.recurse=true if user enables feature.experimental flag

From: Mahi Kolla <hidden>
Date: 2021-08-13 20:48:37

Mahi mentioned wanting to rework her commit to use a config besides
'feature.experimental' for this same behavior, so hopefully we will see
that change come through soon - but today is also the last day of her
internship, so we may not be so lucky.
This change is pretty much good to go! I implemented it under
`submodule.stickyRecursiveClone`. The commit is actually in the PR.
Just wanted to hear more from you guys before submitting :)
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help