# Re: \[PATCH 4/7\] grep: read submodule entry with explicit repo

- From: Jonathan Tan \<hidden\>
- Date: 2021-08-13 16:39:05 
- List: git
- Page: https://ratatoskr.run/git/2021/08/7899259
- Thread: https://ratatoskr.run/git/2021/08/7898971/t.md

```text
> > -		object = parse_object_or_die(oid, NULL);
> > +		object_type = oid_object_info(&subrepo, oid, NULL);
> 
> One thing I wonder is whether we are missing out on some error
> conditions we used to get with parse_object_or_die() by using
> oid_object_info() instead. Do we need to be more defensive in
> investigating 'oid' before calling that helper, now?

For the purposes of grep, I don't think that this matters - we just want
to find the ultimate tree that this object represents.
```