Re: [PATCH v5] userdiff: improve java hunk header regex

2 messages, 2 authors, 2021-08-11 · open the first message on its own page

Re: [PATCH v5] userdiff: improve java hunk header regex

From: Junio C Hamano <hidden>
Date: 2021-08-11 18:11:12

Tassilo Horn [off-list ref] writes:
That leads to the question if you'd welcome a patch adding a
.dir-locals.el to the repository with the right settings so that it'll
just work for contributors using the One True Editor.  Would you?
If your one true editor honored what is in .editorconfig, perhaps
there was no need for us to be having this conversation?  I dunno.

Our .gitattributes (the top one and also in subdirectories) try to
give reasonable whitespace rules for files, and specifically, files
in t/t????/ directories that are used as test vectors completely
disable whitespace checking, while everywhere else we insist certain
styles in the top-level .gitattributes file.

Thanks.

Re: [PATCH v5] userdiff: improve java hunk header regex

From: Tassilo Horn <hidden>
Date: 2021-08-11 19:05:21

Junio C Hamano [off-list ref] writes:
quoted
That leads to the question if you'd welcome a patch adding a
.dir-locals.el to the repository with the right settings so that
it'll just work for contributors using the One True Editor.  Would
you?
If your one true editor honored what is in .editorconfig, perhaps
there was no need for us to be having this conversation?  I dunno.
Ah, I'm sorry, I wasn't aware of that.  I've installed the editorconfig
Emacs plugin [1] which seems to do the trick.

Bye,
Tassilo

[1] https://github.com/editorconfig/editorconfig-emacs
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help