Re: [PATCH 0/2] fsmonitor: fixup to avoid warnings from pedantic

Jeff Hostetler [off-list ref] writes:

On 8/9/21 2:30 AM, Carlo Marcelo Arenas Belón wrote:

quoted

seen with both clang 12 and gcc 11 in seen (including jh/builtin-fsmonitor)
as of a5a42b9f76 (from Jul 1)
it should be squashed into the corresponding patch from the series
as shown
in the subject and reroll IMHO; notice Junio also has some bandaid sparse
fixes for t/helper/test-touch.c that should be included.
a similar additional fix for C89 compatibility to be send as a reply
later
Carlo Marcelo Arenas Belón (2):
   fixup! fsmonitor-ipc: create client routines for git-fsmonitor--daemon
   fixup! fsmonitor--daemon: implement handle_client callback
  builtin/fsmonitor--daemon.c | 2 +-
  fsmonitor-ipc.h             | 2 ++
  2 files changed, 3 insertions(+), 1 deletion(-)

Thanks!

Thanks, both.  

Jeff, I understand that this is planned to be rerolled post release,
so I'll not touch these fixups and let yuou worry about them ;-)

On Mon, Aug 9, 2021 at 9:49 AM Junio C Hamano [off-list ref] wrote:

Jeff, I understand that this is planned to be rerolled post release,
so I'll not touch these fixups and let you worry about them ;-)

Jeff,

As I mentioned in the cover letter[1] there is an extra patch[2] not
in the series and that also applies to maint, but is not critical and
might be better if included with your reroll IMHO, thanks.

Carlo

[1] https://lore.kernel.org/git/20210809063004.73736-1-carenas@gmail.com/
[2] https://lore.kernel.org/git/20210809072551.94391-1-carenas@gmail.com/

On 8/10/21 1:49 AM, Carlo Arenas wrote:

On Mon, Aug 9, 2021 at 9:49 AM Junio C Hamano [off-list ref] wrote:

quoted

Jeff, I understand that this is planned to be rerolled post release,
so I'll not touch these fixups and let you worry about them ;-)

Jeff,

As I mentioned in the cover letter[1] there is an extra patch[2] not
in the series and that also applies to maint, but is not critical and
might be better if included with your reroll IMHO, thanks.

Carlo

[1] https://lore.kernel.org/git/20210809063004.73736-1-carenas@gmail.com/
[2] https://lore.kernel.org/git/20210809072551.94391-1-carenas@gmail.com/

You're talking about the commit with "%lf" vs "%f".

I saw that, but I was unsure what it had to do with my FSMonitor
series.  It seemed like it could just be a standalone patch by itself.

(I'm not opposed to including it in mine, but it'd be easier and
quicker to just treat it in isolation, IMHO.)

Thoughts??

Jeff

On 8/9/21 12:49 PM, Junio C Hamano wrote:

Jeff Hostetler [off-list ref] writes:

quoted

On 8/9/21 2:30 AM, Carlo Marcelo Arenas Belón wrote:

quoted

seen with both clang 12 and gcc 11 in seen (including jh/builtin-fsmonitor)
as of a5a42b9f76 (from Jul 1)
it should be squashed into the corresponding patch from the series
as shown
in the subject and reroll IMHO; notice Junio also has some bandaid sparse
fixes for t/helper/test-touch.c that should be included.
a similar additional fix for C89 compatibility to be send as a reply
later
Carlo Marcelo Arenas Belón (2):
    fixup! fsmonitor-ipc: create client routines for git-fsmonitor--daemon
    fixup! fsmonitor--daemon: implement handle_client callback
   builtin/fsmonitor--daemon.c | 2 +-
   fsmonitor-ipc.h             | 2 ++
   2 files changed, 3 insertions(+), 1 deletion(-)

Thanks!

Thanks, both.

Jeff, I understand that this is planned to be rerolled post release,
so I'll not touch these fixups and let yuou worry about them ;-)

Right. I'll include them with my next version.
Jeff