Re: [PATCH v2 00/11] Fix direct filesystem access in various test files.

Han-Wen Nienhuys [off-list ref] writes:

On Fri, Jul 23, 2021 at 7:44 PM Junio C Hamano [off-list ref] wrote:

quoted

"Han-Wen Nienhuys via GitGitGadget" [off-list ref] writes:

quoted

This fixes a few test failures in the reftable series.

The early part is already in 'next', and the new ones looked mostly
good.

I didn't quite understand what was going on with "ls -1" though
(what does it even mean to "ls -1" enumerate only the filenames in
.git/reftable directory)?

By listing the files before and after, we can make sure that the ref
storage wasn't changed.

Meaning that we rely on the fact that we never append to an existing
file?  A comment here would have helped.

Thanks.

On Mon, Aug 2, 2021 at 6:28 PM Junio C Hamano [off-list ref] wrote:

quoted

By listing the files before and after, we can make sure that the ref
storage wasn't changed.

Meaning that we rely on the fact that we never append to an existing
file?  A comment here would have helped.

Added some more explanation.

I addressed your comments for the other changes (but forgot to update
the cover letter :-/ )

-- 
Han-Wen Nienhuys - Google Munich
I work 80%. Don't expect answers from me on Fridays.
--

Google Germany GmbH, Erika-Mann-Strasse 33, 80636 Munich

Registergericht und -nummer: Hamburg, HRB 86891

Sitz der Gesellschaft: Hamburg

Geschäftsführer: Paul Manicle, Halimah DeLaine Prado