[PATCH] http.c: use error_errno(), not error() after fopen() failure
From: Ævar Arnfjörð Bjarmason <hidden>
Date: 2021-07-27 00:07:40
Subsystem:
the rest · Maintainer:
Linus Torvalds
Improve the error reporting added in e929cd20bb3 (http.c: new functions for the http API, 2009-06-06) to emit strerror(), as fopen() is a failing system call we'll have a meaningful errno to report. Signed-off-by: Ævar Arnfjörð Bjarmason <redacted> --- http.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/http.c b/http.c
index 8119247149..f7940f1b5e 100644
--- a/http.c
+++ b/http.c@@ -2341,8 +2341,8 @@ struct http_pack_request *new_direct_http_pack_request( strbuf_addf(&preq->tmpfile, "%s.temp", sha1_pack_name(packed_git_hash)); preq->packfile = fopen(preq->tmpfile.buf, "a"); if (!preq->packfile) { - error("Unable to open local file %s for pack", - preq->tmpfile.buf); + error_errno("Unable to open local file %s for pack", + preq->tmpfile.buf); goto abort; }
--
2.32.0.988.g1a6a4b2c5f