Re: [PATCH v3 4/5] Makefile: the "cscope" target always creates a "cscope.out"
From: Junio C Hamano <hidden>
Date: 2021-07-22 16:57:42
Possibly related (same subject, not in this thread)
- 2021-07-22 · Re: [PATCH v3 4/5] Makefile: the "cscope" target always creates a "cscope.out" · Ævar Arnfjörð Bjarmason <hidden>
- 2021-07-22 · Re: [PATCH v3 4/5] Makefile: the "cscope" target always creates a "cscope.out" · Junio C Hamano <hidden>
- 2021-07-21 · [PATCH v3 4/5] Makefile: the "cscope" target always creates a "cscope.out" · Ævar Arnfjörð Bjarmason <hidden>
Ævar Arnfjörð Bjarmason [off-list ref] writes:
In the preceding commit the "cscope" target was changed to be a phony alias for the "cscope.out" target. The cscope target was added in a2a9150bf06 (makefile: Add a cscope target, 2007-10-06), and has always referred to cscope* instead of to cscope.out. As far as I can tell this ambiguity was never needed. The "-fcscope.out" (note, no whitespace) argument is enabled by default, but let's provide it explicitly for good measure.
Isn't it because we anticipated possible use of options like '-q' in the future that we clean and ignore cscope* instead of the single cscope.out and nothing else? $ echo *.c | xargs cscope -b -q; git clean -n -x Would remove cscope.in.out Would remove cscope.out Would remove cscope.po.out I know we currently care only about cscope.out and it is perfectly fine to make the phony cscope depend on cscope.out only, but I'd feel safer to keep the exclude patterns and $(RM) clean rule to catch them.
quoted hunk
Signed-off-by: Ævar Arnfjörð Bjarmason <redacted> --- .gitignore | 2 +- Makefile | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-)diff --git a/.gitignore b/.gitignore index 311841f9bed..d74029c1ca7 100644 --- a/.gitignore +++ b/.gitignore@@ -217,7 +217,7 @@ /.vscode/ /tags /TAGS -/cscope* +/cscope.out /compile_commands.json *.hcc *.objdiff --git a/Makefile b/Makefile index 18895d94ffa..730ff23b923 100644 --- a/Makefile +++ b/Makefile@@ -2752,8 +2752,8 @@ tags: $(FOUND_SOURCE_FILES) mv tags+ tags cscope.out: $(FOUND_SOURCE_FILES) - $(QUIET_GEN)$(RM) cscope* && \ - echo $(FOUND_SOURCE_FILES) | xargs cscope -b + $(QUIET_GEN)$(RM) cscope.out && \ + echo $(FOUND_SOURCE_FILES) | xargs cscope -f$@ -b .PHONY: cscope cscope: cscope.out@@ -3230,7 +3230,7 @@ clean: profile-clean coverage-clean cocciclean $(RM) $(HCC) $(RM) -r bin-wrappers $(dep_dirs) $(compdb_dir) compile_commands.json $(RM) -r po/build/ - $(RM) *.pyc *.pyo */*.pyc */*.pyo $(GENERATED_H) $(ETAGS_TARGET) tags cscope* + $(RM) *.pyc *.pyo */*.pyc */*.pyo $(GENERATED_H) $(ETAGS_TARGET) tags cscope.out $(RM) -r .dist-tmp-dir .doc-tmp-dir $(RM) $(GIT_TARNAME).tar.gz $(RM) $(htmldocs).tar.gz $(manpages).tar.gz