From: Felipe Contreras <hidden> Date: 2021-06-21 16:58:51
I already sent the first part of this series separately multiple times,
the last one is 4 simple obviously correct patches [1], but since the
maintainer has admitted he has no problem ignoring valid work
entirely due to personal animus [2], I'm sending the whole chain.
There's no point in carefully selecting multiple series of patches to be
merged one by one when all of them are going to be ignored. So I'm
sending all 3 series at once.
Hopefully by sending it all at once some people will be able to realize
that:
1. They are valid
2. They are helpful
3. They make the code more maintainable
4. They enable new features
5. They enable the new features to be easily tested
6. They reduce the doc-diff of the new feature, as well as others
7. They are superior to the competing series currently in seen
8. They include work of multiple contributors
Any fair and impartial maintainer would attempt to pick them up.
Cheers.
[1] https://lore.kernel.org/git/20210618215231.796592-1-felipe.contreras@gmail.com/
[2] https://lore.kernel.org/git/xmqqmtrmjpa8.fsf@gitster.g/
Felipe Contreras (21):
doc: remove GNU troff workaround
doc: use --stringparam in xmlto
doc: simplify version passing
doc: asciidoc: remove unnecessary attribute
doc: asciidoctor: remove unnecessary require
doc: asciidoctor: remove cruft
doc: asciidoctor: reorganize extensions
doc: asciidoctor: use html-prefix only for html
doc: asciidoctor: refactor macro registration
doc: asciidoctor: improve string handling
doc: asciidoctor: split the format from the code
doc: asciidoctor: specify name of our group
doc: doc-diff: set docdate manually
doc: use asciidoctor to build man pages directly
doc: asciidoctor: add linkgit macros in man pages
doc: add man pages workaround for asciidoctor
doc: asciidoctor: add hack for xrefs
doc: asciidoctor: add hack to improve links
doc: asciidoctor: add support for baseurl
doc: asciidoctor: cleanup man page hack
doc: asciidoctor: add hack for old versions
Jeff King (1):
doc-diff: support asciidoctor man pages
Martin Ågren (1):
doc-diff: drop --cut-footer switch
Documentation/.gitignore | 1 -
Documentation/Makefile | 32 ++++----
Documentation/asciidoc.conf | 20 -----
Documentation/asciidoctor-extensions.rb | 103 +++++++++++++++---------
Documentation/doc-diff | 38 ++++-----
Documentation/manpage-base-url.xsl.in | 10 ---
Documentation/manpage-quote-apos.xsl | 16 ----
Makefile | 8 +-
8 files changed, 104 insertions(+), 124 deletions(-)
delete mode 100644 Documentation/manpage-base-url.xsl.in
delete mode 100644 Documentation/manpage-quote-apos.xsl
--
2.32.0
From: Felipe Contreras <hidden> Date: 2021-06-21 16:58:45
In 2007 the docbook project made the mistake of converting ' to \' for
man pages [1]. It's a problem because groff interprets \' as acute
accent which is rendered as ' in ASCII, but as ´ in utf-8.
This started a cascade of bug reports in git [2], debian [3], Arch Linux
[4], docbook itself [5], and probably many others.
A solution was to use the correct groff character: \(aq, which is always
rendered as ', but the problem is that such character doesn't work in
other troff programs.
A portable solution required the use of a conditional character that is
\(aq in groff, but ' in all others:
.ie \n(.g .ds Aq \(aq
.el .ds Aq '
The proper solution took time to be implemented in docbook, but in 2010
they did it [6]. So the docbook man page stylesheets were broken from
1.73 to 1.76.
Unfortunately by that point many workarounds already existed. In the
case of git GNU_ROFF was introduced, and in the case of Arch Linux
a mappig from \' to ' was added to groff's man.local. Other
distributions might have done the same, or similar workarounds.
Since 2010 there is not need for this workaround, which is fixed
elsewhere not just in docbook, but other layers as well.
Let's remove it.
Also, it's GNU troff, not GNU roff.
[1] https://github.com/docbook/xslt10-stylesheets/commit/ea2a0bac56c56eec1892ac3d9254dca89f7c5746
[2] https://lore.kernel.org/git/20091012102926.GA3937@debian.b2j/
[3] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=507673#65
[4] https://bugs.archlinux.org/task/9643
[5] https://sourceforge.net/p/docbook/bugs/1022/
[6] https://github.com/docbook/xslt10-stylesheets/commit/fb553434265906ed81edc6d5f533d0b08d200046
Inspired-by: brian m. carlson [off-list ref]
Signed-off-by: Felipe Contreras <redacted>
---
Documentation/Makefile | 8 --------
Documentation/manpage-quote-apos.xsl | 16 ----------------
Makefile | 4 ----
3 files changed, 28 deletions(-)
delete mode 100644 Documentation/manpage-quote-apos.xsl
@@ -178,14 +178,6 @@ MAN_BASE_URL = file://$(htmldir)/endifXMLTO_EXTRA+=-mmanpage-base-url.xsl-# If your target system uses GNU groff, it may try to render-# apostrophes as a "pretty" apostrophe using unicode. This breaks-# cut&paste, so you should set GNU_ROFF to force them to be ASCII-# apostrophes. Unfortunately does not work with non-GNU roff.-ifdef GNU_ROFF-XMLTO_EXTRA+=-mmanpage-quote-apos.xsl-endif-ifdef USE_ASCIIDOCTORASCIIDOC=asciidoctorASCIIDOC_CONF=
@@ -1,16 +0,0 @@-<xsl:stylesheet xmlns:xsl="http://www.w3.org/1999/XSL/Transform"- version="1.0">--<!-- work around newer groff/man setups using a prettier apostrophe- that unfortunately does not quote anything when cut&pasting- examples to the shell -->-<xsl:template name="escape.apostrophe">- <xsl:param name="content"/>- <xsl:call-template name="string.subst">- <xsl:with-param name="string" select="$content"/>- <xsl:with-param name="target">'</xsl:with-param>- <xsl:with-param name="replacement">\(aq</xsl:with-param>- </xsl:call-template>-</xsl:template>--</xsl:stylesheet>
@@ -278,10 +278,6 @@ all::# Define NO_ST_BLOCKS_IN_STRUCT_STAT if your platform does not have st_blocks# field that counts the on-disk footprint in 512-byte blocks.#-# Define GNU_ROFF if your target system uses GNU groff. This forces-# apostrophes to be ASCII so that cut&pasting examples to the shell-# will work.-## Define USE_ASCIIDOCTOR to use Asciidoctor instead of AsciiDoc to build the# documentation.#
From: Felipe Contreras <hidden> Date: 2021-06-21 16:58:47
The code to pass the version of the man page comes from 2007:
7ef195ba3e (Documentation: Add version information to man pages,
2007-03-25). However, both asciidoc and asciidoctor already do this by
default.
Asciidoctor doesn't read manversion, but there's no need since both
tools just join mansource and manversion.
Let's do that ourselves and get rid of a bunch of code.
Signed-off-by: Felipe Contreras <redacted>
---
Documentation/Makefile | 3 +--
Documentation/asciidoc.conf | 19 -------------------
Documentation/asciidoctor-extensions.rb | 17 -----------------
3 files changed, 1 insertion(+), 38 deletions(-)
From: Felipe Contreras <hidden> Date: 2021-06-21 16:58:49
Commit 50d9bbba92 (Documentation: Avoid use of xmlto --stringparam,
2009-12-04) introduced manpage-base-url.xsl because ancient versions of
xmlto did not have --stringparam.
However, that was more than ten years ago, no need for that complexity
anymore.
Signed-off-by: Felipe Contreras <redacted>
---
Documentation/.gitignore | 1 -
Documentation/Makefile | 8 ++------
Documentation/manpage-base-url.xsl.in | 10 ----------
3 files changed, 2 insertions(+), 17 deletions(-)
delete mode 100644 Documentation/manpage-base-url.xsl.in
@@ -1,10 +0,0 @@-<!-- manpage-base-url.xsl:- special settings for manpages rendered from newer docbook -->-<xsl:stylesheet xmlns:xsl="http://www.w3.org/1999/XSL/Transform"- version="1.0">--<!-- set a base URL for relative links -->-<xsl:param name="man.base.url.for.relative.links"- >@@MAN_BASE_URL@@</xsl:param>--</xsl:stylesheet>
From: Felipe Contreras <hidden> Date: 2021-06-21 16:58:53
It's part of asciidoc global configuration since 2012.
Signed-off-by: Felipe Contreras <redacted>
---
Documentation/asciidoc.conf | 1 -
1 file changed, 1 deletion(-)
From: Felipe Contreras <hidden> Date: 2021-06-21 16:58:55
This file is loaded by asciidoctor, the module is already loaded.
In addition to being less redundant this fixes a problem while trying
use a development version of asciidoctor when the gem is available:
$GEM_HOME/gems/asciidoctor-2.0.15/lib/asciidoctor.rb:51:
warning: already initialized constant Asciidoctor::RUBY_ENGINE
$HOME/asciidoctor/lib/asciidoctor.rb:52:
warning: previous definition of RUBY_ENGINE was here
...
That's a bug in asciidoctor, but there's no need to trigger it.
Signed-off-by: Felipe Contreras <redacted>
---
Documentation/asciidoctor-extensions.rb | 1 -
1 file changed, 1 deletion(-)
From: Felipe Contreras <hidden> Date: 2021-06-21 16:59:00
There's no need to create verbose classes, we can do the same with a
simple block.
Signed-off-by: Felipe Contreras <redacted>
---
Documentation/asciidoctor-extensions.rb | 34 +++++++++++--------------
1 file changed, 15 insertions(+), 19 deletions(-)
From: Felipe Contreras <hidden> Date: 2021-06-21 16:59:02
These were probably copy-pasted from other extensions. The name is
already defined (:linkgit), and we are not using the DSL mode.
Signed-off-by: Felipe Contreras <redacted>
---
Documentation/asciidoctor-extensions.rb | 4 ----
1 file changed, 4 deletions(-)
From: Felipe Contreras <hidden> Date: 2021-06-21 16:59:03
Using printf style formatting (more familiar to git developers), and
also here document.
Signed-off-by: Felipe Contreras <redacted>
---
Documentation/asciidoctor-extensions.rb | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)
From: Felipe Contreras <hidden> Date: 2021-06-21 16:59:08
This way we don't have to specify the block to execute on every
conditional.
Signed-off-by: Felipe Contreras <redacted>
---
Documentation/asciidoctor-extensions.rb | 26 ++++++++++++-------------
1 file changed, 13 insertions(+), 13 deletions(-)
From: Felipe Contreras <hidden> Date: 2021-06-21 16:59:08
There is no need to execute extra code every time the process block is
called.
In Ruby the lexical scope is shared, so we can define variables in the
register block scope, and all the rest will inherit those variables.
Based on the doctype and basebackend one of three blocks is selected for
the inline_macro. However, the conditionals will be run only once.
In the end Ruby will only run the code between `process do end`, nothing
else.
Signed-off-by: Felipe Contreras <redacted>
---
Documentation/asciidoctor-extensions.rb | 16 +++++++++++-----
1 file changed, 11 insertions(+), 5 deletions(-)
From: Felipe Contreras <hidden> Date: 2021-06-21 16:59:13
Doesn't do anything, but otherwise we get a random name.
Signed-off-by: Felipe Contreras <redacted>
---
Documentation/asciidoctor-extensions.rb | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
From: Felipe Contreras <hidden> Date: 2021-06-21 16:59:26
In order to minimize the differences in the footer.
Asciidoc automatically generates a date with format '%Y-%m-%d', while
asciidoctor '%F'.
I personally prefer the latter, so only modify it for diff purposes.
Fixes tons of these:
-Git omitted 01/01/1970 GIT-ADD(1)
+Git omitted 1970-01-01 GIT-ADD(1)
Note that we have to add quotes when passing around $makemanflags, as it
now may contain whitespace due to multiple arguments (but the
dereference inside render_tree must remain unquoted, because it wants to perform
whitespace splitting to get the individual arguments back).
Comments-by: Jeff King [off-list ref]
Signed-off-by: Felipe Contreras <redacted>
---
Documentation/Makefile | 2 +-
Documentation/doc-diff | 6 +++---
2 files changed, 4 insertions(+), 4 deletions(-)
From: Felipe Contreras <hidden> Date: 2021-06-21 16:59:30
From: Martin Ågren <redacted>
Now that our doc-diff convinces Asciidoctor to insert the exact same
formatted dummy date as AsciiDoc, we can drop the --cut-footer switch.
It has been useful to ignore this difference between the two tools, but
it's effectively a no-op now. Similar to when we repurposed this from
--cut-header-footer in 83b0b8953e ("doc-diff: replace
--cut-header-footer with --cut-footer", 2019-09-16), just drop it
without worrying about any kind of backwards compatibility or user-base.
Signed-off-by: Martin Ågren <redacted>
Signed-off-by: Felipe Contreras <redacted>
---
Documentation/doc-diff | 18 ++----------------
1 file changed, 2 insertions(+), 16 deletions(-)
@@ -21,7 +21,6 @@ asciidoc use asciidoc with both commits to-asciidoc use asciidoc with the 'to'-commit to-asciidoctor use asciidoctor with the 'to'-commit asciidoctor use asciidoctor with both commits-cut-footer cut away footer " SUBDIRECTORY_OK=1 . "$(git --exec-path)/git-sh-setup"
@@ -31,7 +30,6 @@ force= clean= from_program= to_program=-cut_footer= while test $# -gt 0 do case "$1" in
From: Felipe Contreras <hidden> Date: 2021-06-21 16:59:32
There's no need to use xmlto to build the man pages when modern
asciidoctor can do it by itself.
This new mode will be active only when both USE_ASCIIDOCTOR and
USE_ASCIIDOCTOR_MANPAGE are set.
Suggested-by: Bagas Sanjaya <redacted>
Suggestions-by: Jeff King [off-list ref]
Signed-off-by: Felipe Contreras <redacted>
---
Documentation/Makefile | 10 +++++++++-
Makefile | 4 ++++
2 files changed, 13 insertions(+), 1 deletion(-)
@@ -281,6 +281,10 @@ all::# Define USE_ASCIIDOCTOR to use Asciidoctor instead of AsciiDoc to build the# documentation.#+# Define USE_ASCIIDOCTOR_MANPAGE to use Asciidoctor's manual page backend+# instead of building manual pages from DocBook (using xmlto). Has no effect+# unless USE_ASCIIDOCTOR is set.+## Define ASCIIDOCTOR_EXTENSIONS_LAB to point to the location of the Asciidoctor# Extensions Lab if you have it available.#
From: Felipe Contreras <hidden> Date: 2021-06-21 16:59:32
From: Jeff King <redacted>
The new option enables both asciidoctor as well as its direct-to-manpage
mode that skips xmlto. This lets you view the rendered difference
between the two pipelines with something like:
./doc-diff --from-asciidoctor --to-asciidoctor-direct HEAD HEAD
Signed-off-by: Jeff King <redacted>
Signed-off-by: Felipe Contreras <redacted>
---
Documentation/doc-diff | 14 ++++++++++++++
1 file changed, 14 insertions(+)
@@ -17,10 +17,13 @@ f force rebuild; do not rely on cached results c,clean cleanup temporary working files from-asciidoc use asciidoc with the 'from'-commit from-asciidoctor use asciidoctor with the 'from'-commit+from-asciidoctor-direct use asciidoctor without xmlto for 'from'-commit asciidoc use asciidoc with both commits to-asciidoc use asciidoc with the 'to'-commit to-asciidoctor use asciidoctor with the 'to'-commit+to-asciidoctor-direct use asciidoctor without xmlto for 'to'-commit asciidoctor use asciidoctor with both commits+asciidoctor-direct use asciidoctor without xml for both commits " SUBDIRECTORY_OK=1 . "$(git --exec-path)/git-sh-setup"
From: Felipe Contreras <hidden> Date: 2021-06-21 16:59:48
The docbook manpage stylesheets convert cross-references with format the
'section called “%t”'. I personally prefer the asciidoctor version, but
for now add a hack to minimize the diff.
Thanks to the extensibility of Ruby we can override corresponding method
in the man page converter.
This fixes doc-diffs like:
--worktree-attributes
Look for attributes in .gitattributes files in the working tree as
- well (see the section called “ATTRIBUTES”).
+ well (see ATTRIBUTES).
This can easily be removed later once we are confortable with the
asciidoctor version.
Signed-off-by: Felipe Contreras <redacted>
---
Documentation/asciidoctor-extensions.rb | 18 ++++++++++++++++++
1 file changed, 18 insertions(+)
@@ -1,4 +1,22 @@require'asciidoctor/extensions'+require'asciidoctor/converter/manpage'++moduleAsciidoctor+classConverter::ManPageConverter+aliasorig_convert_inline_anchorconvert_inline_anchor+defconvert_inline_anchor(node)+casenode.type+when:xref+returnnode.textifnode.text+refid=node.attributes['refid']+'the section called “%s”'%refid.gsub('_',' ')+else+orig_convert_inline_anchor(node)+end+end+aliasinline_anchorconvert_inline_anchor# For old versions of asciidoctor+end+endAsciidoctor::Extensions.register:gitdo
From: Felipe Contreras <hidden> Date: 2021-06-21 16:59:49
The way asciidoctor handles links is very primitive compared to docbook.
Links are simply presented in the format "#{text} <#{target}>", which
may not be all that bad for the future, but pollutes the doc-diff.
By adding another modification to convert_inline_anchor() we can present
links in a form very similar to docbook, diminishing the doc-diff.
This significantly reduces the doc-diff:
From:
abysmal performance). These safety and performance issues cannot be
backward compatibly fixed and as such, its use is not recommended.
Please use an alternative history filtering tool such as git
- filter-repo[1]. If you still need to use git filter-branch, please
- carefully read the section called “SAFETY” (and the section called
- “PERFORMANCE”) to learn about the land mines of filter-branch, and then
- vigilantly avoid as many of the hazards listed there as reasonably
- possible.
+ <https://github.com/newren/git-filter-repo/> filter-repo" . If you
+ still need to use git filter-branch, please carefully read the section
+ called “SAFETY” (and the section called “PERFORMANCE”) to learn about
+ the land mines of filter-branch, and then vigilantly avoid as many of
+ the hazards listed there as reasonably possible.
-NOTES
- 1. git filter-repo
- https://github.com/newren/git-filter-repo/
-
- 2. filter-lamely
- https://github.com/newren/git-filter-repo/blob/master/contrib/filter-repo-demos/filter-lamely
-
To:
NOTES
- 1. git filter-repo
+ [1] git filter-repo
https://github.com/newren/git-filter-repo/
Signed-off-by: Felipe Contreras <redacted>
---
Documentation/asciidoctor-extensions.rb | 13 +++++++++++++
1 file changed, 13 insertions(+)
From: Felipe Contreras <hidden> Date: 2021-06-21 16:59:51
There's basically nothing we need from the original
orig_convert_inline_anchor(), so let's remove calls to it.
Signed-off-by: Felipe Contreras <redacted>
---
Documentation/asciidoctor-extensions.rb | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
@@ -25,8 +24,10 @@ module Asciidoctorend"\e\\fB%s\e\\fR[%d]"%[node.text,footnote.index]+when:ref,:bibref+''else-orig_convert_inline_anchor(node)+nilendendaliasinline_anchorconvert_inline_anchor# For old versions of asciidoctor
From: Felipe Contreras <hidden> Date: 2021-06-21 16:59:53
Fixes the doc-diff:
- Please see git-commit(1) for alternative ways to add content to a
- commit.
+ Please see for alternative ways to add content to a commit.
Comments-by: brian m. carlson [off-list ref]
Signed-off-by: Felipe Contreras <redacted>
---
Documentation/asciidoctor-extensions.rb | 2 ++
1 file changed, 2 insertions(+)
From: Felipe Contreras <hidden> Date: 2021-06-21 16:59:55
Currently asciidoctor doesn't convert number character references
(&#xx;) correctly for man pages.
This hack fixes the issue with minimum changes elsewhere so it's easy to
remove when fixed.
Fixes doc-diffs like:
so line count cannot be shown) and there is no difference between
indexed copy and the working tree version (if the working tree
version were also different, binary would have been shown in place
- of nothing). The other file, git-add--interactive.perl, has 403
- lines added and 35 lines deleted if you commit what is in the
- index, but working tree file has further modifications (one
+ of nothing). The other file, git-add--interactive.perl,
+ has 403 lines added and 35 lines deleted if you commit what is in
+ the index, but working tree file has further modifications (one
addition and one deletion).
https://github.com/asciidoctor/asciidoctor/issues/4059
Signed-off-by: Felipe Contreras <redacted>
---
Documentation/asciidoctor-extensions.rb | 6 ++++++
1 file changed, 6 insertions(+)
@@ -38,10 +38,19 @@ Asciidoctor::Extensions.register :git dodoc=document-# Override attributes for man pages.-# https://github.com/asciidoctor/asciidoctor/issues/4059ifdoc.backend=='manpage'+# Override attributes for man pages.+# https://github.com/asciidoctor/asciidoctor/issues/4059doc.attributes.merge!({'litdd'=>'\--','plus'=>'+'})++# Fix bug with \\+ifAsciidoctor::VERSION<'2.0.11'+postprocessordo+processdo|_,output|+output.gsub("\\(rs\\\\","\\(rs\\(rs\\")+end+end+endendinline_macro:linkgitdo
From: Felipe Contreras <hidden> Date: 2021-06-21 17:00:01
So that we can present relative links correctly.
Reduces the doc-diff:
NOTES
- 1. “Understanding history: What is a branch?”
- file:///$HOME/share/doc/git-doc/user-manual.html#what-is-a-branch
+ [1] “Understanding history: What is a branch?”
+ user-manual.html#what-is-a-branch
NOTES
- 1. “Understanding history: What is a branch?”
+ [1] “Understanding history: What is a branch?”
file:///$HOME/share/doc/git-doc/user-manual.html#what-is-a-branch
Signed-off-by: Felipe Contreras <redacted>
---
Documentation/Makefile | 1 +
Documentation/asciidoctor-extensions.rb | 4 +++-
2 files changed, 4 insertions(+), 1 deletion(-)
+# Define USE_ASCIIDOCTOR_MANPAGE to use Asciidoctor's manual page backend
+# instead of building manual pages from DocBook (using xmlto). Has no effect
+# unless USE_ASCIIDOCTOR is set.
+#
Why not just USE_ASCIIDOCTOR_MANPAGE implies USE_ASCIIDOCTOR?
--
An old man doll... just what I always wanted! - Clara
I already sent the first part of this series separately multiple times,
the last one is 4 simple obviously correct patches [1], but since the
maintainer has admitted he has no problem ignoring valid work
entirely due to personal animus [2], I'm sending the whole chain.
There's no point in carefully selecting multiple series of patches to be
merged one by one when all of them are going to be ignored. So I'm
sending all 3 series at once.
Hopefully by sending it all at once some people will be able to realize
that:
1. They are valid
2. They are helpful
3. They make the code more maintainable
4. They enable new features
5. They enable the new features to be easily tested
6. They reduce the doc-diff of the new feature, as well as others
7. They are superior to the competing series currently in seen
8. They include work of multiple contributors
Any fair and impartial maintainer would attempt to pick them up.
Cheers.
I think the next step after this patch series is to add asciidoctor
direct man pages generation option to ./configure script (maybe
--enable-asciidoctor-manpage?). But before that, we need to add
--enable-asciidoctor option, which sets USE_ASCIIDOCTOR=YesPlease.
--
An old man doll... just what I always wanted! - Clara
From: Felipe Contreras <hidden> Date: 2021-06-23 01:35:47
Bagas Sanjaya wrote:
On 21/06/21 23.31, Felipe Contreras wrote:
quoted
+# Define USE_ASCIIDOCTOR_MANPAGE to use Asciidoctor's manual page backend
+# instead of building manual pages from DocBook (using xmlto). Has no effect
+# unless USE_ASCIIDOCTOR is set.
+#
Why not just USE_ASCIIDOCTOR_MANPAGE implies USE_ASCIIDOCTOR?
Personally I don't see the point of USE_ASCIIDOCTOR_MANPAGE at all. The
only reason I added it was because Martin requested it [1].
It would be nice of you and Martin could make a decision about this, and
I would just implement what you decide (or other people willing to
collaborate on this).
I don't have an opinion on this.
If no decision is reached, I'll make USE_ASCIIDOCTOR_MANPAGE imply
USE_ASCIIDOCTOR as you suggest.
Cheers.
[1] https://lore.kernel.org/git/CAN0heSpX53tK8Z4XSx4sp79b+XWKZg5+ABW8pmzBSHPZ+qy+oQ@mail.gmail.com/
--
Felipe Contreras
From: Felipe Contreras <hidden> Date: 2021-06-23 01:37:08
Bagas Sanjaya wrote:
On 21/06/21 23.30, Felipe Contreras wrote:
quoted
I already sent the first part of this series separately multiple times,
the last one is 4 simple obviously correct patches [1], but since the
maintainer has admitted he has no problem ignoring valid work
entirely due to personal animus [2], I'm sending the whole chain.
There's no point in carefully selecting multiple series of patches to be
merged one by one when all of them are going to be ignored. So I'm
sending all 3 series at once.
Hopefully by sending it all at once some people will be able to realize
that:
1. They are valid
2. They are helpful
3. They make the code more maintainable
4. They enable new features
5. They enable the new features to be easily tested
6. They reduce the doc-diff of the new feature, as well as others
7. They are superior to the competing series currently in seen
8. They include work of multiple contributors
Any fair and impartial maintainer would attempt to pick them up.
Cheers.
I think the next step after this patch series is to add asciidoctor
direct man pages generation option to ./configure script (maybe
--enable-asciidoctor-manpage?). But before that, we need to add
--enable-asciidoctor option, which sets USE_ASCIIDOCTOR=YesPlease.
Maybe. I don't use ./configure, so perhaps somebody that does should
take charge of this.
--
Felipe Contreras