[PATCH resend] graph: improve grammar of "invalid color" error message

Subsystems: the rest

STALE1882d

2 messages, 2 authors, 2021-06-13 · open the first message on its own page

[PATCH resend] graph: improve grammar of "invalid color" error message

From: Alex Henrie <hidden>
Date: 2021-06-12 18:43:20

Without the "d", it sounds like a command, not an error, and is liable
to be translated incorrectly.

Signed-off-by: Alex Henrie <redacted>
---
Resending to make sure that this patch isn't forgotten.
---
 graph.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/graph.c b/graph.c
index c128ad0cce..e3828eb8f2 100644
--- a/graph.c
+++ b/graph.c
@@ -95,7 +95,7 @@ static void parse_graph_colors_config(struct strvec *colors, const char *string)
 		if (!color_parse_mem(start, comma - start, color))
 			strvec_push(colors, color);
 		else
-			warning(_("ignore invalid color '%.*s' in log.graphColors"),
+			warning(_("ignored invalid color '%.*s' in log.graphColors"),
 				(int)(comma - start), start);
 		start = comma + 1;
 	}
-- 
2.31.1

Re: [PATCH resend] graph: improve grammar of "invalid color" error message

From: Bagas Sanjaya <hidden>
Date: 2021-06-13 02:22:54

Hi,

On 13/06/21 01.41, Alex Henrie wrote:
Without the "d", it sounds like a command, not an error, and is liable
to be translated incorrectly.
s/liable/prone/
quoted hunk
Signed-off-by: Alex Henrie <redacted>
---
Resending to make sure that this patch isn't forgotten.
---
  graph.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/graph.c b/graph.c
index c128ad0cce..e3828eb8f2 100644
--- a/graph.c
+++ b/graph.c
@@ -95,7 +95,7 @@ static void parse_graph_colors_config(struct strvec *colors, const char *string)
  		if (!color_parse_mem(start, comma - start, color))
  			strvec_push(colors, color);
  		else
-			warning(_("ignore invalid color '%.*s' in log.graphColors"),
+			warning(_("ignored invalid color '%.*s' in log.graphColors"),
  				(int)(comma - start), start);
  		start = comma + 1;
  	}
Why did you resend the patch?

-- 
An old man doll... just what I always wanted! - Clara
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help