Re: [PATCH 0/6] [GSOC][RFC] ref-filter: add %(raw:textconv) and %(raw:filters)

2 messages, 2 authors, 2021-06-07 · open the first message on its own page

Re: [PATCH 0/6] [GSOC][RFC] ref-filter: add %(raw:textconv) and %(raw:filters)

From: Junio C Hamano <hidden>
Date: 2021-06-07 05:56:05

"ZheNing Hu via GitGitGadget" [off-list ref] writes:
The current series is based on 0efed9435 ([GSOC] ref-filter: add %(raw)
atom)
I do not have that commit object, but these six patches include the
two commits that are %(raw) and %(raw:size), so I'll just discard
the old round that wasn't based on the atom-type stuff and queue
these six as a single series.

As I already said, I am not sure how %(rest) makes any sense outside
the context of "cat-file --batch"; I suspect it would make more sense
to make it easier to arrange certain placeholders to error out when
used in a context where they do not make sense (e.g. use of --rest
in "git branch --list").

Re: [PATCH 0/6] [GSOC][RFC] ref-filter: add %(raw:textconv) and %(raw:filters)

From: ZheNing Hu <hidden>
Date: 2021-06-07 13:08:07

Junio C Hamano [off-list ref] 于2021年6月7日周一 下午1:56写道:
"ZheNing Hu via GitGitGadget" [off-list ref] writes:
quoted
The current series is based on 0efed9435 ([GSOC] ref-filter: add %(raw)
atom)
I do not have that commit object, but these six patches include the
two commits that are %(raw) and %(raw:size), so I'll just discard
the old round that wasn't based on the atom-type stuff and queue
these six as a single series.
Well, it is a commit that has not been sent to the mailing list. But it’s okay
to treat the new 6 commits as a new patch series.
As I already said, I am not sure how %(rest) makes any sense outside
the context of "cat-file --batch"; I suspect it would make more sense
to make it easier to arrange certain placeholders to error out when
used in a context where they do not make sense (e.g. use of --rest
in "git branch --list").
I agree.

--
ZheNing Hu
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help