[PATCH] Remove warning that repack only works on non-promisor packfiles

From: Tao Klerks <redacted>

The git-repack doc clearly states that it *does* operate on promisor
packfiles (in a separate partition), with "-a" specified. Presumably
the statements here are outdated, as they feature from the first doc
in 2017 (and the repack support was added in 2018)

Signed-off-by: Tao Klerks <redacted>
---
    Remove warning that repack only works on non-promisor packfiles
    
    The git-repack doc clearly states that it does operate on promisor
    packfiles (in a separate partition), with "-a" specified. Presumably the
    statements here are outdated, as they feature from the first doc in 2017
    (and the repack support was added in 2018)

Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-968%2FTaoK%2Fpatch-1-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-968/TaoK/patch-1-v1
Pull-Request: https://github.com/gitgitgadget/git/pull/968

 Documentation/technical/partial-clone.txt | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/Documentation/technical/partial-clone.txt b/Documentation/technical/partial-clone.txt
index 0780d30caca6..a0dd7c66f247 100644
--- a/Documentation/technical/partial-clone.txt
+++ b/Documentation/technical/partial-clone.txt

@@ -242,8 +242,7 @@ remote in a specific order.
   repository and can satisfy all such requests.
 
 - Repack essentially treats promisor and non-promisor packfiles as 2
-  distinct partitions and does not mix them.  Repack currently only works
-  on non-promisor packfiles and loose objects.
+  distinct partitions and does not mix them.
 
 - Dynamic object fetching invokes fetch-pack once *for each item*
   because most algorithms stumble upon a missing object and need to have

@@ -273,9 +272,6 @@ to use those promisor remotes in that order."
 The user might want to work in a triangular work flow with multiple
 promisor remotes that each have an incomplete view of the repository.
 
-- Allow repack to work on promisor packfiles (while keeping them distinct
-  from non-promisor packfiles).
-
 - Allow non-pathname-based filters to make use of packfile bitmaps (when
   present).  This was just an omission during the initial implementation.
 

base-commit: ed125c4f07ba69c53c9f4d74ff395a4bf7854ea7
-- 
gitgitgadget

On Wed, Jun 02, 2021 at 11:47:26AM +0000, Tao Klerks via GitGitGadget wrote:

From: Tao Klerks <redacted>

The git-repack doc clearly states that it *does* operate on promisor
packfiles (in a separate partition), with "-a" specified. Presumably
the statements here are outdated, as they feature from the first doc
in 2017 (and the repack support was added in 2018)

Yeah, this all originally comes from Jeff H.'s design document in
637fc4467e (partial-clone: design doc, 2017-12-14), but probably should
have been updated in 5d19e8138d (repack: repack promisor objects if -a
or -A is set, 2018-08-08).

This looks good to me, but I'll add Jonathan Tan to the CC list to
double check.

  Reviewed-by: Taylor Blau [off-list ref]

Thanks,
Taylor

On Wed, Jun 02, 2021 at 11:47:26AM +0000, Tao Klerks via GitGitGadget wrote:

quoted

From: Tao Klerks <redacted>

The git-repack doc clearly states that it *does* operate on promisor
packfiles (in a separate partition), with "-a" specified. Presumably
the statements here are outdated, as they feature from the first doc
in 2017 (and the repack support was added in 2018)

Yeah, this all originally comes from Jeff H.'s design document in
637fc4467e (partial-clone: design doc, 2017-12-14), but probably should
have been updated in 5d19e8138d (repack: repack promisor objects if -a
or -A is set, 2018-08-08).

This looks good to me, but I'll add Jonathan Tan to the CC list to
double check.

  Reviewed-by: Taylor Blau [off-list ref]

Thanks, Taylor. Yes, the patch is correct.