# Re: \[PATCH\]\[GSoC\] submodule: introduce add-clone helper for submodule add

- From: Atharva Raykar \<hidden\>
- Date: 2021-06-02 08:19:01 
- List: git
- Page: https://ratatoskr.run/git/2021/06/7890261
- Thread: https://ratatoskr.run/git/2021/05/7889801/t.md

```text


> On 02-Jun-2021, at 13:25, Atharva Raykar [ref] wrote:
> 
> [...]
> I've not yet fully developed a taste for good C style, so I wanted
> to ask, which one looks better to you in these?
> 
> /* Sample 1 */
> while (begin != end && (line = get_next_line(begin, end))) {
> 	char *name, *url, *tail;
> 	name = parse_token(&begin, next_line);
> 	url = parse_token(&begin, next_line);
> 	tail = parse_token(&begin, next_line);
> 	...
> }
> 
> /* Sample 2 */
> while (begin != end && (line = get_next_line(begin, end))) {
> 	char *name = parse_token(&begin, next_line);
> 	char *url = parse_token(&begin, next_line);
> 	char *tail = parse_token(&begin, next_line);
> 	...
> }

Also ignore the error here, assume: s/next_line/line/
(Anyway, my question was about style)
```