Re: [PATCH v3 0/5] doc: asciidoc cleanups

Jeff King [off-list ref] writes:

On Tue, May 25, 2021 at 02:51:54AM +0900, Junio C Hamano wrote:

quoted

quoted

 Documentation/Makefile | 77 ++++++++++++++++--------------------------
 1 file changed, 29 insertions(+), 48 deletions(-)

Is this satisfactory to everybody (I haven't taken a look beyond
comparing the end results)?

Yes, all five patches look good to me.

The issue that it interacts in a funny way with what brian already
has in 'seen' aside, the patches look good to me, too, so let's
start merging it down.

The "comments-by" sub-thread looked unproductive to me, so I mostly
skipped it. ;) But as the person whose name was in the trailer, I will
say that I do not care either way if it is included. It did not seem to
add anything to me. Some trailers are good for pointing later readers to
folks who may be able to help understand or debug an old commit. Some
are good for just giving credit to people who helped. "Comments-by"
didn't really seem to do either to me (and I don't feel like I
contributed much worthy of credit anyway).

Exactly the same feeling.  It didn't add any value that was why I
saw no point in using something almost nobody uses (instead of the
more commonly used Helped-by, for example).

Thanks.

Junio C Hamano wrote:

Jeff King [off-list ref] writes:

quoted

The "comments-by" sub-thread looked unproductive to me, so I mostly
skipped it. ;) But as the person whose name was in the trailer, I will
say that I do not care either way if it is included. It did not seem to
add anything to me. Some trailers are good for pointing later readers to
folks who may be able to help understand or debug an old commit. Some
are good for just giving credit to people who helped. "Comments-by"
didn't really seem to do either to me (and I don't feel like I
contributed much worthy of credit anyway).

Exactly the same feeling.  It didn't add any value that was why I
saw no point in using something almost nobody uses (instead of the
more commonly used Helped-by, for example).

As I demonstrated with probabilistic certainty; everyone uses uncommon
lines (including you). The fact that a line is uncommon doesn't
necessarily mean it's bad, in fact, I do see value in going outside the
box (like one of my favorites: Brown-paper-bag-fixes-by [4981fe750b]).

And of course if you find Comments-by so egregious, you can amend my
commit message (as you have done many times in the past). But this might
be a good opportunity to exercise the advice Jeff gave in another
thread, and even if you are not 100% happy with something, let it slide.

Cheers.

-- 
Felipe Contreras