3 messages, 3 authors, 2021-06-22 · open the first message on its own page
From: Junio C Hamano <hidden>
Date: 2021-05-27 02:06:21
These new global symbols are introduced by the series, but never used outside the file they are added to: fsmonitor-ipc.o - fsmonitor_ipc__get_path fsmonitor-ipc.o - fsmonitor_ipc__get_state fsmonitor-ipc.o - fsmonitor_ipc__send_command Perhaps make them file-scope static? Thanks.
From: Johannes Schindelin <hidden>
Date: 2021-06-02 11:29:05
Hi Junio, On Thu, 27 May 2021, Junio C Hamano wrote:
These new global symbols are introduced by the series, but never used outside the file they are added to: fsmonitor-ipc.o - fsmonitor_ipc__get_path fsmonitor-ipc.o - fsmonitor_ipc__get_state fsmonitor-ipc.o - fsmonitor_ipc__send_command Perhaps make them file-scope static?
Good idea! By the way, GitGitGadget keeps getting confused by the fact that one of Peff's patches looks very similar to the tip commit of this here patch series, and mislabels Jeff's PR as being closed. Would you terribly mind picking up v2 some time soon so that I do not have to click "Reopen" on Jeff's PR all the time (I had to reopen it a couple times already: https://github.com/gitgitgadget/git/pull/923, and I do lack the time to teach GitGitGadget new tricks to avoid this mislabeling). Thank you, Dscho
From: Jeff Hostetler <hidden>
Date: 2021-06-22 15:45:42
On 5/26/21 10:06 PM, Junio C Hamano wrote:
These new global symbols are introduced by the series, but never used outside the file they are added to: fsmonitor-ipc.o - fsmonitor_ipc__get_path fsmonitor-ipc.o - fsmonitor_ipc__get_state fsmonitor-ipc.o - fsmonitor_ipc__send_command Perhaps make them file-scope static?
I intended these to be part of the API for talking to a builtin FSMonitor. They are called from builtin/fsmonitor--daemon.c and t/helper/test-fsmonitor-client.c Jeff