Re: [PATCH v6] [GSOC] ref-filter: fix read invalid union member bug

"ZheNing Hu via GitGitGadget" [off-list ref] writes:

+test_expect_success '%(color:#aa22ac) must succeed' '
+	mkdir test &&

You do not need "mkdir test" here, as "git init test" would take
care of it.

On the other hand, you'd want to get 'test' directory removed after
this passes, so 

	test_when_finished rm -fr test &&

would be useful.

Other than that, looks good to me.

Thanks.

+	git init test &&
+	(
+		cd test &&
+		test_commit initial &&
+		git branch -M main &&
+		cat >expect <<-\EOF &&
+		refs/heads/main
+		refs/tags/initial
+		EOF
+		git remote add origin nowhere &&
+		git config branch.main.remote origin &&
+		git config branch.main.merge refs/heads/main &&
+		git for-each-ref --format="%(color:#aa22ac)%(refname)" >actual &&
+		test_cmp expect actual
+	)
+'
+
 test_expect_success 'left alignment is default' '
 	cat >expect <<-\EOF &&
 	refname is refs/heads/main    |refs/heads/main

base-commit: 311531c9de557d25ac087c1637818bd2aad6eb3a

Junio C Hamano [off-list ref] 于2021年5月13日周四 上午7:24写道：

"ZheNing Hu via GitGitGadget" [off-list ref] writes:

quoted

+test_expect_success '%(color:#aa22ac) must succeed' '
+     mkdir test &&

You do not need "mkdir test" here, as "git init test" would take
care of it.

Make sence.

On the other hand, you'd want to get 'test' directory removed after
this passes, so

        test_when_finished rm -fr test &&

would be useful.

Well, deleting or not deleting the directory "test" is not a big problem here.
Delete it is ok.

Other than that, looks good to me.

Thanks.

Thanks.
--
ZheNing Hu