Re: Blob hash of binary files in patches generated by git format patch show in full form instead of short form

3 messages, 2 authors, 2021-03-22 · open the first message on its own page

Re: Blob hash of binary files in patches generated by git format patch show in full form instead of short form

From: Junio C Hamano <hidden>
Date: 2021-03-21 17:32:34

Bagas Sanjaya [off-list ref] writes:
What's different between what you expected and what actually happened?

Blob hash for binary files are shown in full form, as opposed to blob hash
for text files.
This is working as intended, designed and implemented.  

The textual patch is meant to be applicable on target text that may
even have been slightly modified from the original from which the
patch was taken, and the abbreviated object name on the "index" line
is there mostly for human's sanity check and as a visual aid.
Ordinarily it is not used to actually find the matching blob object
(and it is not an error if there is no matching blob object in the
repository that a patch application is attempted in).

But the binary patch is designed to be applicable only to an exact
copy of the original and nowhere else.  The object name is given in
full, instead of using abbreviated form, to ensure that we do not
try to apply a binary patch to an object whose name is "similar".

Thanks.

Re: Blob hash of binary files in patches generated by git format patch show in full form instead of short form

From: Bagas Sanjaya <hidden>
Date: 2021-03-22 05:48:30

On 22/03/21 00.31, Junio C Hamano wrote:
Bagas Sanjaya [off-list ref] writes:
quoted
What's different between what you expected and what actually happened?

Blob hash for binary files are shown in full form, as opposed to blob hash
for text files.
This is working as intended, designed and implemented.

The textual patch is meant to be applicable on target text that may
even have been slightly modified from the original from which the
patch was taken, and the abbreviated object name on the "index" line
is there mostly for human's sanity check and as a visual aid.
Ordinarily it is not used to actually find the matching blob object
(and it is not an error if there is no matching blob object in the
repository that a patch application is attempted in).

But the binary patch is designed to be applicable only to an exact
copy of the original and nowhere else.  The object name is given in
full, instead of using abbreviated form, to ensure that we do not
try to apply a binary patch to an object whose name is "similar".

Thanks.
Hmm... but I don't see that in the documentation for git format-patch.
Maybe I need to send doc update.

-- 
An old man doll... just what I always wanted! - Clara

Re: Blob hash of binary files in patches generated by git format patch show in full form instead of short form

From: Bagas Sanjaya <hidden>
Date: 2021-03-22 10:07:30

Oh oh oh, I see git diff format for generating patches in documentation for
git diff-files.

On 22/03/21 12.47, Bagas Sanjaya wrote:
On 22/03/21 00.31, Junio C Hamano wrote:
quoted
Bagas Sanjaya [off-list ref] writes:
quoted
What's different between what you expected and what actually happened?

Blob hash for binary files are shown in full form, as opposed to blob hash
for text files.
This is working as intended, designed and implemented.

The textual patch is meant to be applicable on target text that may
even have been slightly modified from the original from which the
patch was taken, and the abbreviated object name on the "index" line
is there mostly for human's sanity check and as a visual aid.
Ordinarily it is not used to actually find the matching blob object
(and it is not an error if there is no matching blob object in the
repository that a patch application is attempted in).

But the binary patch is designed to be applicable only to an exact
copy of the original and nowhere else.  The object name is given in
full, instead of using abbreviated form, to ensure that we do not
try to apply a binary patch to an object whose name is "similar".

Thanks.
Hmm... but I don't see that in the documentation for git format-patch.
Maybe I need to send doc update.
-- 
An old man doll... just what I always wanted! - Clara
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help