Re: [PATCH v2 2/2] [GSOC] interpret-trailer: easy parse trailer value

Christian Couder [off-list ref] writes:

quoted

"Signed-off-by:C O [off-list ref]" is often too
verbose and error-prone.

The 'trailer.<token>.command' config option can already be used to
help with that, for example:

-------
$ git config trailer.sign.key "Signed-off-by: "
$ git config trailer.sign.ifexists replace
$ git config trailer.sign.command "git log --author='\$ARG' -1
--format='format:%aN <%aE>'"
$ git interpret-trailers --trailer sign=Linus<<EOF
subject

body
EOF
subject

body

Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
-------

So even without this patch, after your first patch that implements
`git commit --trailer ...`, it should be easy to setup something less
verbose and less error-prone.

It is nice that it makes the complexity of 2/2 unnecessary ;-)

Junio C Hamano [off-list ref] 于2021年3月22日周一 上午12:52写道：

Christian Couder [off-list ref] writes:

quoted

quoted

"Signed-off-by:C O [off-list ref]" is often too
verbose and error-prone.

The 'trailer.<token>.command' config option can already be used to
help with that, for example:

-------
$ git config trailer.sign.key "Signed-off-by: "
$ git config trailer.sign.ifexists replace
$ git config trailer.sign.command "git log --author='\$ARG' -1
--format='format:%aN <%aE>'"
$ git interpret-trailers --trailer sign=Linus<<EOF
subject

body
EOF
subject

body

Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
-------

So even without this patch, after your first patch that implements
`git commit --trailer ...`, it should be easy to setup something less
verbose and less error-prone.

It is nice that it makes the complexity of 2/2 unnecessary ;-)

A little frustrated, both `--own-identity` and `@nickname` seem to be
 rejected. I will roll back to the first patch.

On Mon, Mar 22, 2021 at 1:39 AM ZheNing Hu [off-list ref] wrote:

Junio C Hamano [off-list ref] 于2021年3月22日周一 上午12:52写道：

quoted

Christian Couder [off-list ref] writes:

quoted

quoted

So even without this patch, after your first patch that implements
`git commit --trailer ...`, it should be easy to setup something less
verbose and less error-prone.

It is nice that it makes the complexity of 2/2 unnecessary ;-)

A little frustrated, both `--own-identity` and `@nickname` seem to be
 rejected. I will roll back to the first patch.

It's good to want to implement new features, and to come up quickly
with patches, but it's also good to give people time on this list to
discuss the goals you would like to achieve, and which features are
already available or should be implement to achieve the goals.

Thanks for working on this topic anyway!

Christian Couder [off-list ref] 于2021年3月22日周一 下午3:26写道：

On Mon, Mar 22, 2021 at 1:39 AM ZheNing Hu [off-list ref] wrote:

quoted

Junio C Hamano [off-list ref] 于2021年3月22日周一 上午12:52写道：

quoted

Christian Couder [off-list ref] writes:

quoted

quoted

quoted

So even without this patch, after your first patch that implements
`git commit --trailer ...`, it should be easy to setup something less
verbose and less error-prone.

It is nice that it makes the complexity of 2/2 unnecessary ;-)

A little frustrated, both `--own-identity` and `@nickname` seem to be
 rejected. I will roll back to the first patch.

It's good to want to implement new features, and to come up quickly
with patches, but it's also good to give people time on this list to
discuss the goals you would like to achieve, and which features are
already available or should be implement to achieve the goals.

I basically started coding after receiving the first reviewer's comment.
It seems that I should be more patient.

Thanks for working on this topic anyway!

Thanks, Christian.

ZheNing Hu [off-list ref] writes:

Junio C Hamano [off-list ref] 于2021年3月22日周一 上午12:52写道：

quoted

Christian Couder [off-list ref] writes:
...

quoted

So even without this patch, after your first patch that implements
`git commit --trailer ...`, it should be easy to setup something less
verbose and less error-prone.

It is nice that it makes the complexity of 2/2 unnecessary ;-)

A little frustrated, both `--own-identity` and `@nickname` seem to be
 rejected. I will roll back to the first patch.

If existing functionality can be used to achieve the same end result
without any extra effort by end-users, that's a happy endgame, isn't
it?  There isn't a reason to be frustrated---the users benefit with
the new --trailer option without adding (hence having to learn) new
extra features like --own-ident or @name, which is a big plus.

Junio C Hamano [off-list ref] 于2021年3月23日周二 上午1:07写道：

ZheNing Hu [off-list ref] writes:

quoted

Junio C Hamano [off-list ref] 于2021年3月22日周一 上午12:52写道：

quoted

Christian Couder [off-list ref] writes:
...

quoted

So even without this patch, after your first patch that implements
`git commit --trailer ...`, it should be easy to setup something less
verbose and less error-prone.

It is nice that it makes the complexity of 2/2 unnecessary ;-)

A little frustrated, both `--own-identity` and `@nickname` seem to be
 rejected. I will roll back to the first patch.

If existing functionality can be used to achieve the same end result
without any extra effort by end-users, that's a happy endgame, isn't
it?  There isn't a reason to be frustrated---the users benefit with
the new --trailer option without adding (hence having to learn) new
extra features like --own-ident or @name, which is a big plus.

Thanks, Junio, you are right :)