Re: [PATCH] Fix a typo in git-maintenance documentation

2 messages, 2 authors, 2021-03-19 · open the first message on its own page

Re: [PATCH] Fix a typo in git-maintenance documentation

From: Junio C Hamano <hidden>
Date: 2021-03-19 17:55:59

"Nils Leif Fischer via GitGitGadget" [off-list ref]
writes:
From: Nils Leif Fischer <redacted>

Signed-off-by: Nils Leif Fischer <redacted>
---
    Fix typo in git-maintenance documentation
    
    Just a small typo.
This is from the very beginning at 2057d750 (maintenance: create
basic maintenance runner, 2020-09-17), I think.
quoted hunk
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-git-984%2Fnilsleiffischer%2Fnilsleiffischer-patch-1-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-git-984/nilsleiffischer/nilsleiffischer-patch-1-v1
Pull-Request: https://github.com/git/git/pull/984

 Documentation/git-maintenance.txt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/git-maintenance.txt b/Documentation/git-maintenance.txt
index 80ddd33ceba0..8023504dc65d 100644
--- a/Documentation/git-maintenance.txt
+++ b/Documentation/git-maintenance.txt
@@ -106,7 +106,7 @@ any object transfer.
 
 gc::
 	Clean up unnecessary files and optimize the local repository. "GC"
-	stands for "garbage collection," but this task performs many
+	stands for "garbage collection", but this task performs many
Isn't this merely an American style vs British style issue?

 	smaller tasks. This task can be expensive for large repositories,
 	as it repacks all Git objects into a single pack-file. It can also
 	be disruptive in some situations, as it deletes stale data. See

base-commit: a5828ae6b52137b913b978e16cd2334482eb4c1f

cf.

https://www.grammarly.com/blog/quotation-marks
https://www.thepunctuationguide.com/british-versus-american-style.html
https://owl.purdue.edu/owl/general_writing/punctuation/quotation_marks/more_quotation_mark_rules.html

Re: [PATCH] Fix a typo in git-maintenance documentation

From: Derrick Stolee <hidden>
Date: 2021-03-19 18:38:23

On 3/19/2021 1:55 PM, Junio C Hamano wrote:
"Nils Leif Fischer via GitGitGadget" [off-list ref]
quoted
 gc::
 	Clean up unnecessary files and optimize the local repository. "GC"
-	stands for "garbage collection," but this task performs many
+	stands for "garbage collection", but this task performs many
Isn't this merely an American style vs British style issue?
Yes, I believe so.
https://www.grammarly.com/blog/quotation-marks
https://www.thepunctuationguide.com/british-versus-american-style.html
https://owl.purdue.edu/owl/general_writing/punctuation/quotation_marks/more_quotation_mark_rules.html
Specifically, this quote from your first link:

  Commas and periods always go inside the quotation marks in
  American English; dashes, colons, and semicolons almost always
  go outside the quotation marks; question marks and exclamation
  marks sometimes go inside, sometimes stay outside.

The only time I break this is when the exact string matters,
such as referencing an exact command with options. In those
cases, I try to restructure the sentence to avoid having a
comma or period outside of the quote.

Thanks,
-Stolee
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help