Re: [PATCH v6 0/6][Outreachy] commit: Implementation of "amend!" commit

Charvi Mendiratta [off-list ref] writes:

This patch series teaches `git commit --fixup` to create "amend!" commit
as an alternative that works with `git rebase --autosquash`. It allows to
fixup both the content and the commit message of the specified commit.
Here we add two suboptions to the `--fixup`, first `amend` suboption that
creates an "amend!" commit. It takes the staged changes and also allows to
edit the commit message of the commit we are fixing.
Example usuage:
git commit --fixup=amend:<commit>

Secondly, `reword` suboption that creates an empty "amend!" commit i.e it
ignores the staged changes and only allows to reword/edit the commit message
of the commit we are fixing. `--fixup=reword:<commit>` is a short-hand of
`--fixup=amend:<commit> --only`.
Example usuage:
git commit --fixup=reword:<commit>

** This work is rebased on the top of cm/rebase-i-updates.

Are people happy with this round?  I gave an extra round of
eyeballing and didn't see anything suspicious, so I am planning to
merge it to 'next' soonish once the dust settles post release.

Thanks.

On Thu, Mar 18, 2021 at 8:53 PM Junio C Hamano [off-list ref] wrote:

Charvi Mendiratta [off-list ref] writes:

quoted

Example usuage:
git commit --fixup=amend:<commit>

Are people happy with this round?  I gave an extra round of
eyeballing and didn't see anything suspicious, so I am planning to
merge it to 'next' soonish once the dust settles post release.

I gave the series a final read-through when v6 was posted and didn't
find anything about which to comment. I think all my review comments
on earlier versions have been addressed, so I have no objection to
seeing it merged to 'next'.

On Fri, 19 Mar 2021 at 08:46, Eric Sunshine [off-list ref] wrote:

On Thu, Mar 18, 2021 at 8:53 PM Junio C Hamano [off-list ref] wrote:

quoted

Charvi Mendiratta [off-list ref] writes:

quoted

Example usuage:
git commit --fixup=amend:<commit>

Are people happy with this round?  I gave an extra round of
eyeballing and didn't see anything suspicious, so I am planning to
merge it to 'next' soonish once the dust settles post release.

I gave the series a final read-through when v6 was posted and didn't
find anything about which to comment. I think all my review comments
on earlier versions have been addressed, so I have no objection to
seeing it merged to 'next'.

I too agree, thanks for confirming.

Thanks and Regards,
Charvi