Re: [PATCH v3 00/20] Sparse Index: Design, Format, Tests

2 messages, 2 authors, 2021-03-19 · open the first message on its own page

Re: [PATCH v3 00/20] Sparse Index: Design, Format, Tests

From: Junio C Hamano <hidden>
Date: 2021-03-18 21:50:51

"Derrick Stolee via GitGitGadget" [off-list ref] writes:
For this version, I took Ævar's latest patches and applied them to v2.31.0
and rebased this series on top. It uses his new "read_tree_at()" helper and
the associated changes to the function pointer type.

 * Fixed more typos. Thanks Martin and Elijah!
 * Updated the test_sparse_match() macro to use "$@" instead of $*
 * Added a test that git sparse-checkout init --no-sparse-index rewrites the
   index to be full.
Thanks.  I expect ab/read-tree would be rerolled at least one more
time, if only to straighten out the "oops #5 was screwy, let's patch
it up on top with three more steps", but I do not expect the end
state would be all that different, so tentatively I'll queue these
patches on top of the latest iteration of the topic for now and
hope that the other topic will be updated soonish.

Re: [PATCH v3 00/20] Sparse Index: Design, Format, Tests

From: Derrick Stolee <hidden>
Date: 2021-03-19 13:01:06


On 3/18/2021 5:50 PM, Junio C Hamano wrote:
"Derrick Stolee via GitGitGadget" [off-list ref] writes:
quoted
For this version, I took Ævar's latest patches and applied them to v2.31.0
and rebased this series on top. It uses his new "read_tree_at()" helper and
the associated changes to the function pointer type.

 * Fixed more typos. Thanks Martin and Elijah!
 * Updated the test_sparse_match() macro to use "$@" instead of $*
 * Added a test that git sparse-checkout init --no-sparse-index rewrites the
   index to be full.
Thanks.  I expect ab/read-tree would be rerolled at least one more
time, if only to straighten out the "oops #5 was screwy, let's patch
it up on top with three more steps", but I do not expect the end
state would be all that different, so tentatively I'll queue these
patches on top of the latest iteration of the topic for now and
hope that the other topic will be updated soonish.
Thanks. I'm grateful that it can spend some time in 'seen' if only
to avoid these conflicts in the meantime.

I'm waiting for that reroll of ab/read-tree before updating this
version with the feedback from v3.

Thanks,
-Stolee
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help