Re: [PATCH] [GSOC] commit: provides multiple common signatures

3 messages, 2 authors, 2021-03-12 · open the first message on its own page

Re: [PATCH] [GSOC] commit: provides multiple common signatures

From: Junio C Hamano <hidden>
Date: 2021-03-11 17:30:08

"ZheNing Hu via GitGitGadget" [off-list ref] writes:
From: ZheNing Hu <redacted>

Similar to "Helped-by", "Reported-by", "Reviewed-by", "Mentored-by"
these signatures are often seen in git commit messages. After
referring to the simple implementation of `commit --signoff`
and `send-email -cc=" commiter <email>"`, I am considering
whether to provide multiple signature parameters from the
command line.
+ ...
+	>file6 &&
+	git add file6 &&
+	git commit -H "foo <bar@frotz>" \
+	-R "foo2 <bar2@frotz>" \
+	-M "foo3 <bar3@frotz>" \
+	-r "foo4 <bar4@frotz>" -s -m "thank you" &&
Firm NAK.

Especially, not in this form that squats on short-and-sweet single
letter option names only to support the convention of this single
project (namely, Git).

cf. https://lore.kernel.org/git/20200824061156.1929850-1-espeer@gmail.com/

Thanks.

Re: [PATCH] [GSOC] commit: provides multiple common signatures

From: ZheNing Hu <hidden>
Date: 2021-03-12 12:01:50

Junio C Hamano [off-list ref] 于2021年3月12日周五 上午1:29写道:
Firm NAK.

Especially, not in this form that squats on short-and-sweet single
letter option names only to support the convention of this single
project (namely, Git).

cf. https://lore.kernel.org/git/20200824061156.1929850-1-espeer@gmail.com/

Thanks.
Well, Junio, you point is It's also worth thinking about, This
"trailer =<trailer>:<argtrailer>" is probably the more general
version of the tailer I want to provide to commit, Then I may
need to know how Christian Couder `trailer.c` work first,or can
you give a little directionality guidance?

Thanks.

Re: [PATCH] [GSOC] commit: provides multiple common signatures

From: ZheNing Hu <hidden>
Date: 2021-03-12 13:24:08

Junio C Hamano [off-list ref] 于2021年3月12日周五 上午1:29写道:
Firm NAK.

Especially, not in this form that squats on short-and-sweet single
letter option names only to support the convention of this single
project (namely, Git).

cf. https://lore.kernel.org/git/20200824061156.1929850-1-espeer@gmail.com/

Thanks.
Now I understand that We have a git command now:

`git interpret-trailers --in-place --where=end \
./a.txt --trailer "Signed-off-by:adl [off-list ref] " `
can add the trailers to specified file, so now maybe I only
need to provide `--trailer` for commit, right?
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help