Re: [PATCH] mktag tests: fix broken "&&" chain

Ævar Arnfjörð Bjarmason  [off-list ref] writes:

Remove a stray "xb" I inadvertently introduced in 780aa0a21e0 (tests:
remove last uses of GIT_TEST_GETTEXT_POISON=false, 2021-02-11). This
would have been a failed attempt to type "C-x C-b" that snuck into the
code.

The chainlint check did not catch this one, but I don't know where to
start patching the wall-of-sed that is chainlint.sed to fix that.

I do not think the chainlint check is designed to deal with helper
functions, but I wonder why nobody noticed a runtime failure.  Is
this an unused/dead codepath?

On Sun, Mar 7, 2021 at 3:43 PM Junio C Hamano [off-list ref] wrote:

Ævar Arnfjörð Bjarmason  [off-list ref] writes:

quoted

-                     test_must_fail git mktag --no-strict <tag.sig 2>message.no-strict &&xb
+                     test_must_fail git mktag --no-strict <tag.sig 2>message.no-strict &&
                      grep '$2' message.no-strict

I do not think the chainlint check is designed to deal with helper
functions, but I wonder why nobody noticed a runtime failure.  Is
this an unused/dead codepath?

The `git mktag` invocation would still have produced the expected
stderr output regardless of what happens later (by "later", I mean the
failing invocation of the non-existent `xb` command), which means that
the subsequent `grep` will find what it's looking for, making the
function succeed as expected.

Someone looking at the verbose output might have had a chance of
spotting the "xp: not found" error message, but there likely wasn't
any reason to scan the verbose output since the test succeeded.