Re: [PATCH 0/8] Simple IPC Cleanups

Subsystems: the rest

2 messages, 2 authors, 2021-03-05 · open the first message on its own page

Re: [PATCH 0/8] Simple IPC Cleanups

From: Junio C Hamano <hidden>
Date: 2021-03-05 00:25:08

sparse failed seen, so I tentatively added this on top of your
series.

Thanks.

 t/helper/test-simple-ipc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/t/helper/test-simple-ipc.c b/t/helper/test-simple-ipc.c
index 4da63fd30c..42040ef81b 100644
--- a/t/helper/test-simple-ipc.c
+++ b/t/helper/test-simple-ipc.c
@@ -227,7 +227,7 @@ struct cl_args
 	char bytevalue;
 };
 
-struct cl_args cl_args = {
+static struct cl_args cl_args = {
 	.subcommand = NULL,
 	.path = "ipc-test",
 	.token = NULL,

Re: [PATCH 0/8] Simple IPC Cleanups

From: Jeff Hostetler <hidden>
Date: 2021-03-05 21:35:15


On 3/4/21 7:24 PM, Junio C Hamano wrote:
quoted hunk
sparse failed seen, so I tentatively added this on top of your
series.

Thanks.

  t/helper/test-simple-ipc.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/t/helper/test-simple-ipc.c b/t/helper/test-simple-ipc.c
index 4da63fd30c..42040ef81b 100644
--- a/t/helper/test-simple-ipc.c
+++ b/t/helper/test-simple-ipc.c
@@ -227,7 +227,7 @@ struct cl_args
  	char bytevalue;
  };
  
-struct cl_args cl_args = {
+static struct cl_args cl_args = {
  	.subcommand = NULL,
  	.path = "ipc-test",
  	.token = NULL,
Thanks!!

I'll update my copy.

Since things are settling down on the whole simple-ipc series and
we are waiting for the current release cycle to complete before
going any further, I'm going to let this series rest for a bit
in case there are any more comments.

Then I'll combine the 2 parts and rebase/re-roll all of this into
a single series that we can re-eval for "next" post 2.31.

Jeff
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help