Re: [PATCH 00/14] fsck: API improvements

2 messages, 2 authors, 2021-02-18 · open the first message on its own page

Re: [PATCH 00/14] fsck: API improvements

From: Junio C Hamano <hidden>
Date: 2021-02-18 19:33:59

Ævar Arnfjörð Bjarmason [off-list ref] writes:
quoted
Let's get this reviewed now, but with expectation that it will be
rebased after the dust settles.
Makes sense. Pending a review of this would you be interested in queuing
a v2 of this that doesn't conflict with in-flight topics?
Not really.  I am not sure your recent patches are getting
sufficient review bandwidth they deserve.
Patches 01..09 & 13/14 can live conflict-free with what's in "seen" now
(I'd have made the 13th the 10th in v1 if I'd noticed). Then I could
re-roll the remainder of this once the other topics land.

Re: [PATCH 00/14] fsck: API improvements

From: Jeff King <hidden>
Date: 2021-02-18 20:01:04

On Thu, Feb 18, 2021 at 11:12:26AM -0800, Junio C Hamano wrote:
Ævar Arnfjörð Bjarmason [off-list ref] writes:
quoted
quoted
Let's get this reviewed now, but with expectation that it will be
rebased after the dust settles.
Makes sense. Pending a review of this would you be interested in queuing
a v2 of this that doesn't conflict with in-flight topics?
Not really.  I am not sure your recent patches are getting
sufficient review bandwidth they deserve.
FWIW, I just read through v2 (without having looked at all at v1 yet!),
and they all seemed like quite reasonable cleanups. I left a few small
comments that might be worth a quick re-roll, but I would also be OK
with the patches being picked up as-is.

-Peff
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help