Re: [PATCH v7] grep: honor sparse-checkout on working tree searches

2 messages, 2 authors, 2021-02-10 · open the first message on its own page

Re: [PATCH v7] grep: honor sparse-checkout on working tree searches

From: Junio C Hamano <hidden>
Date: 2021-02-10 00:11:02

Matheus Tavares [off-list ref] writes:
This new version includes only the bug fix for the working tree grep, as
discussed in [1]. I think there are a couple other patches that could be
extracted from the previous v6 [2] and sent as standalone topics,
without the risk of conflicting with the sparse-index work. E.g. the
unification of the git-grep.txt and config/grep.txt doc files. I'll look
into that tomorrow.
As mt/rm-sparse-checkout depends on the v6 that you are ejecting
with this patch, I'll stop merging that topic to 'seen' for now.

Thanks for keeping an eye on this one.

Re: [PATCH v7] grep: honor sparse-checkout on working tree searches

From: Elijah Newren <hidden>
Date: 2021-02-10 06:22:21

On Tue, Feb 9, 2021 at 3:23 PM Junio C Hamano [off-list ref] wrote:
Matheus Tavares [off-list ref] writes:
quoted
This new version includes only the bug fix for the working tree grep, as
discussed in [1]. I think there are a couple other patches that could be
extracted from the previous v6 [2] and sent as standalone topics,
without the risk of conflicting with the sparse-index work. E.g. the
unification of the git-grep.txt and config/grep.txt doc files. I'll look
into that tomorrow.
As mt/rm-sparse-checkout depends on the v6 that you are ejecting
with this patch, I'll stop merging that topic to 'seen' for now.

Thanks for keeping an eye on this one.
Yeah, Matheus and I have been talking about both topics off-list a
bit; I hadn't yet responded to his final revision of a newer
mt/rm-sparse-checkout but he has a good replacement for that topic now
that he'll send to the list soon.

Anyway, for the patch submitted here you can add a

Reviewed-by: Elijah Newren <redacted>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help