# Re: \[PATCH\] builtin/clone.c: add --no-shallow option

- From: Junio C Hamano \<hidden\>
- Date: 2021-02-04 18:25:50 
- List: git
- Page: https://ratatoskr.run/git/2021/02/7875108
- Thread: https://ratatoskr.run/git/2021/02/7875108/t.md

```text
Johannes Schindelin [ref] writes:

> Hi,
>
> in addition to what Junio said:
>
> On Thu, 4 Feb 2021, Li Linchao via GitGitGadget wrote:
>
>> diff --git a/builtin/clone.c b/builtin/clone.c
>> index e335734b4cfd..b07d867e6641
>> --- a/builtin/clone.c
>> +++ b/builtin/clone.c
>> @@ -858,6 +860,9 @@ static int git_clone_config(const char *k, const char *v, void *cb)
>>  		free(remote_name);
>>  		remote_name = xstrdup(v);
>>  	}
>> +	if (!strcmp(k, "clone.rejectshallow")) {
>> +		option_no_shallow = 1;
>
> This needs to use `git_config_bool(k, v)` to allow for
> `clone.rejectShallow = false`.

Thanks.  I completely missed that.

```