# Re: \[PATCH\] pretty: lazy-load commit data when expanding user-format

- From: Junio C Hamano \<hidden\>
- Date: 2021-01-28 23:26:41 
- List: git
- Page: https://ratatoskr.run/git/2021/01/7874483

```text
Jeff King [ref] writes:

> I added the final test to show where we don't improve (the 1% there is
> just lucky noise), but also as a regression test to make sure we're not
> doing anything stupid like loading the commit multiple times when there
> are several placeholders that need it.
>
> Reported-by: Michael Haggerty <redacted>
> Signed-off-by: Jeff King <redacted>
> ---
> This benefits "rev-list --format=", as well, though there you can also
> use things like "--parents" instead, which are already fast.

Quite pleased to see more work lazily done (and personally I am
happy to see Michael's name on the list---say Hi, I missed him).

```