Re: [PATCH] run-command: document use_shell option

2 messages, 2 authors, 2021-01-23 · open the first message on its own page

Re: [PATCH] run-command: document use_shell option

From: Junio C Hamano <hidden>
Date: 2021-01-22 22:22:43 

Jeff King [off-list ref] writes:
quoted hunk
diff --git a/run-command.h b/run-command.h
index 6472b38bde..d08414a92e 100644
--- a/run-command.h
+++ b/run-command.h
@@ -126,8 +126,15 @@ struct child_process {
 	 */
 	unsigned silent_exec_failure:1;
 
-	unsigned stdout_to_stderr:1;
+	/**
+	 * Run the command from argv[0] using a shell (but note that we may
+	 * still optimize out the shell call if the command contains no
+	 * metacharacters). Note that further arguments to the command in
+	 * argv[1], etc, do not need to be shell-quoted.
+	 */
 	unsigned use_shell:1;
+
+	unsigned stdout_to_stderr:1;
Reads well.  Thanks.

It is curious why "diff" chose to move stdout_to_stderr line around,
though.

 	unsigned clean_on_exit:1;
 	unsigned wait_after_clean:1;
 	void (*clean_on_exit_handler)(struct child_process *process);

Re: [PATCH] run-command: document use_shell option

From: Jeff King <hidden>
Date: 2021-01-23 00:09:01 

On Fri, Jan 22, 2021 at 02:21:15PM -0800, Junio C Hamano wrote:
quoted
-	unsigned stdout_to_stderr:1;
+	/**
+	 * Run the command from argv[0] using a shell (but note that we may
+	 * still optimize out the shell call if the command contains no
+	 * metacharacters). Note that further arguments to the command in
+	 * argv[1], etc, do not need to be shell-quoted.
+	 */
 	unsigned use_shell:1;
+
+	unsigned stdout_to_stderr:1;
Reads well.  Thanks.

It is curious why "diff" chose to move stdout_to_stderr line around,
though.
Heh, I also noticed that and tried a few options to no avail (both
patience/histogram, but also diff.indentHeuristic). It is one deletion
and 8 insertions even if it is done the other way:

  + /*
  + ... 6 more lines ...
  + */
  + unsigned use_shell:1;
  +
    unsigned stdout_to_stderr:1;
  - unsigned use_shell:1;

so it may just come down to the order of xdiff parsing the lines.

-Peff
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help