Kyle Marek [off-list ref] writes:
Me too, but I think a user-defined mark needs to be a string to
support Unicode characters.
Ahh, I didn't even consider making it user-defined.
As it seems a lot safer to make this an optional feature, it does
sort-of make sense to let the letters used for root & left-root be
customizable, and it does make sense to take a multi-byte character,
but I am not sure what implications it has if we allowed any string
without ensuring that it occupies one display column.
On 1/18/21 4:01 PM, Junio C Hamano wrote:
Kyle Marek [off-list ref] writes:
quoted
Me too, but I think a user-defined mark needs to be a string to
support Unicode characters.
Ahh, I didn't even consider making it user-defined.
As it seems a lot safer to make this an optional feature, it does
sort-of make sense to let the letters used for root & left-root be
customizable, and it does make sense to take a multi-byte character,
but I am not sure what implications it has if we allowed any string
without ensuring that it occupies one display column.
Does git, or a dependency library, have the ability to interpret TERM
and locale to determine on-screen character count/size?
If not, maybe let users use multi-character strings, but call it misuse
of the option that will mess offset that row of the --graph output until
we have something to determine on-screen size.
--
-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-
- -
- Kyle Marek PD Inc. http://www.pdinc.us -
- Jr. Developer 10 West 24th Street #100 -
- +1 (443) 269-1555 x361 Baltimore, Maryland 21218 -
- -
-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-