# Re: \[PATCH v2 00/11\] tests: add a bash "set -o pipefail" test mode

- From: Junio C Hamano \<hidden\>
- Date: 2021-01-16 21:51:36 
- List: git
- Page: https://ratatoskr.run/git/2021/01/7872896
- Thread: https://ratatoskr.run/git/2021/01/7872896/t.md

```text
Ævar Arnfjörð Bjarmason  [ref] writes:

> An unstated aim of v1 of this series was to fix up the tests on
> vanilla bash's "set -o pipefail" enough that the test suite would have
> some failures, but wouldn't look like a complete dumpster fire.
>
> But this was confusing and relied on a side-quest to change the
> test_{must,might}_fail helpers. See
> https://lore.kernel.org/git/YAFntgQE3NZ3yQx5@coredump.intra.peff.net/
>
> I've now ejected all of that, in favor of just fixing some of the
> tests instead as Jeff suggested. Jeff, I added your Signed-off-by to
> 06/11 which you're mostly the author of. Please Ack that you're OK
> with that (the original diff-for-discussin didn't have a SOB).

I didn't read the last two pieces that are bash specific, but
everything else was a pleasant read.  I did have a few comments,
though.

Thanks.
```