2 messages, 2 authors, 2021-01-15 · open the first message on its own page
From: Junio C Hamano <hidden>
Date: 2021-01-14 19:59:02
Philippe Blain [off-list ref] writes:
quoted
+SYNOPSIS +-------- +$GIT_WORK_DIR/.mailmapThis should be GIT_WORK_TREE, gitmodules(5) is wrong as GIT_WORK_DIR does not exists (my series at [1] fixes this).
Well spotted. Can you make the suggestion into a follow-up patch to the series to be applied on top? Thanks.
From: Philippe Blain <hidden>
Date: 2021-01-15 02:39:34
Hi Junio Le 2021-01-14 à 14:58, Junio C Hamano a écrit :
Philippe Blain [off-list ref] writes:quoted
quoted
+SYNOPSIS +-------- +$GIT_WORK_DIR/.mailmapThis should be GIT_WORK_TREE, gitmodules(5) is wrong as GIT_WORK_DIR does not exists (my series at [1] fixes this).Well spotted. Can you make the suggestion into a follow-up patch to the series to be applied on top?
I just sent [1] as a fixup! commit (is that what you meant?) I was not sure...) I feel it is cleaner for that commit to use the correct variable name from the start, hence the fixup. Philippe. [1] https://lore.kernel.org/git/87zh1b51xk.fsf@evledraar.gmail.com/T/#m9e8e8f5458db71153c2363acf4bff959df7d0f4c