Re: Cc'ing the Git maintainer on GitGitGadget contributions, was Re: [PATCH 0/1] add--interactive: skip index refresh in reset patch mode

3 messages, 3 authors, 2021-01-14 · open the first message on its own page

Re: Cc'ing the Git maintainer on GitGitGadget contributions, was Re: [PATCH 0/1] add--interactive: skip index refresh in reset patch mode

From: Junio C Hamano <hidden>
Date: 2021-01-10 20:19:34

Johannes Schindelin [off-list ref] writes:
Hi Taylor,

On Fri, 8 Jan 2021, Taylor Blau wrote:
...
quoted
I think that this could be reasonably addressed. When someone opens a PR
(but before the hit /submit), GGG could say:

    Your change touches these files, and so suggested reviewers include
    X, Y, Z. When you believe your submission is in its last round,
    please also include the maintainer, M.
That is an option.
As Taylor created the above suggestion as a counter-proposal, I can
see that I apparently did not express what I meant very well, when I
said:

    Is there a point in the end-user experience flow, starting at
    the time when they push their proposed change to their
    repository, throw a pull request at GitHub, say "/submit", and
    then GGG finally sends out a patch e-mail, where the GGG
    machinery can inspect the change and give the user (preferrably
    before the user says /submit) a hint that says "you may want to
    add Cc: to these people in such and such case, and if you think
    the situation falls into these cases, tell me so by saying
    /submit-with-suggested-cc instead of the usual /submit"?

What Taylor suggested, and what you seem to be agreeing to, is
exactly what I had in mind when I wrote the above in my message.  

So perhaps we three are on the same page from the beginning ;-)

Looking forward to see a new feature that helps contributors to more
easily ask help from appropriate people.

Thanks.

Re: Cc'ing the Git maintainer on GitGitGadget contributions, was Re: [PATCH 0/1] add--interactive: skip index refresh in reset patch mode

From: Taylor Blau <hidden>
Date: 2021-01-11 19:19:17

On Sun, Jan 10, 2021 at 12:18:33PM -0800, Junio C Hamano wrote:
Johannes Schindelin [off-list ref] writes:
quoted
Hi Taylor,

On Fri, 8 Jan 2021, Taylor Blau wrote:
...
quoted
I think that this could be reasonably addressed. When someone opens a PR
(but before the hit /submit), GGG could say:

    Your change touches these files, and so suggested reviewers include
    X, Y, Z. When you believe your submission is in its last round,
    please also include the maintainer, M.
That is an option.
As Taylor created the above suggestion as a counter-proposal, I can
see that I apparently did not express what I meant very well, when I
said:
...or that I must have not read your email which quite clearly states
what I was thinking of, too. ;-).
So perhaps we three are on the same page from the beginning ;-)
I think so.

Thanks,
Taylor

Re: Cc'ing the Git maintainer on GitGitGadget contributions, was Re: [PATCH 0/1] add--interactive: skip index refresh in reset patch mode

From: 胡哲宁 <hidden>
Date: 2021-01-14 06:31:27

Looking forward to see a new feature that helps contributors to more
easily ask help from appropriate people.
I'm a novice with lots of interest but lots of problems.

A week ago, I made the following submission:
https://public-inbox.org/git/pull.832.v2.git.1610116600.gitgitgadget@gmail.com/
https://public-inbox.org/git/0261e5d245ef0a5b9a717be1bc03492d7bc06c5e.1610116600.git.gitgitgadget@gmail.com/
https://public-inbox.org/git/a09a5098aa66ea0ed89fe0fcde3f016b4a65814d.1610116600.git.gitgitgadget@gmail.com/

Now I really want to find the right person to reply to me, but it
seems that no one has answered me yet.
Do I have some mistakes in the use of GIT gadgets? Please tell me and
I will correct it.

Thanks.
--
ZheNing Hu
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help