Re: ss/submodule-add-in-c, was Re: What's cooking in git.git (Dec 2020, #05; Mon, 28)

Johannes Schindelin [off-list ref] writes:

Hi Junio,

On Mon, 28 Dec 2020, Junio C Hamano wrote:

quoted

* ss/submodule-add-in-c (2020-12-15) 3 commits
 . t7400: add test to check 'submodule add' for tracked paths
 . submodule: port submodule subcommand 'add' from shell to C
 . dir: change the scope of function 'directory_exists_in_index()'

 "git submodule add" being rewritten in C.

 Expecting a reroll.
 The patches are split incorrectly; part of 1/3 belongs to 2/3
 cf. [off-list ref]
 It seems to introduce a segfault on 'seen'.
 cf. [off-list ref]

Maybe nycvar.QRO.7.76.6.2012190104140.56@tvgsbejvaqbjf.bet would be a
better reference,...

That is the first message-id referenced in the above, isn't it?

Hi Junio,

On Tue, 5 Jan 2021, Junio C Hamano wrote:

Johannes Schindelin [off-list ref] writes:

quoted

On Mon, 28 Dec 2020, Junio C Hamano wrote:

quoted

* ss/submodule-add-in-c (2020-12-15) 3 commits
 . t7400: add test to check 'submodule add' for tracked paths
 . submodule: port submodule subcommand 'add' from shell to C
 . dir: change the scope of function 'directory_exists_in_index()'

 "git submodule add" being rewritten in C.

 Expecting a reroll.
 The patches are split incorrectly; part of 1/3 belongs to 2/3
 cf. [off-list ref]
 It seems to introduce a segfault on 'seen'.
 cf. [off-list ref]

Maybe nycvar.QRO.7.76.6.2012190104140.56@tvgsbejvaqbjf.bet would be a
better reference,...

That is the first message-id referenced in the above, isn't it?

What I meant was to say that my message clarifies the segfault issue
better than your reply...

Ciao,
Dscho