Jeff King [off-list ref] writes:
I'm still uncertain whether it could all be done in one request for v0.
But one possible solution is: let's not care. If v2 does it correctly,
that's the future anyway (or present; it's now the default in v2.29).
And the change you're proposing in upload-pack would be desirable anyway
to help deal with older clients.
If that's the route we go, we should make sure the commit message
explains it.
Yeah, I'd agree that punting on v0 and making sure the current
version would work well is good enough.
I lost track and am not sure what's the current status of the topic
is. Is v3 [*1*] the latest and satisfactory one?
Thanks.
[Reference]
*1* https://lore.kernel.org/git/20201031023901.48193-1-dan@mutual.io/
On Tue, Nov 03, 2020 at 01:10:53PM -0800, Junio C Hamano wrote:
Jeff King [off-list ref] writes:
quoted
I'm still uncertain whether it could all be done in one request for v0.
But one possible solution is: let's not care. If v2 does it correctly,
that's the future anyway (or present; it's now the default in v2.29).
And the change you're proposing in upload-pack would be desirable anyway
to help deal with older clients.
If that's the route we go, we should make sure the commit message
explains it.
Yeah, I'd agree that punting on v0 and making sure the current
version would work well is good enough.
I lost track and am not sure what's the current status of the topic
is. Is v3 [*1*] the latest and satisfactory one?
Yeah, I just read over v3 again and it looks good to me. Thanks, Daniel!
-Peff
On Wed, Nov 4, 2020 at 5:33 AM Jeff King [off-list ref] wrote:
On Tue, Nov 03, 2020 at 01:10:53PM -0800, Junio C Hamano wrote:
quoted
Yeah, I'd agree that punting on v0 and making sure the current
version would work well is good enough.
I lost track and am not sure what's the current status of the topic
is. Is v3 [*1*] the latest and satisfactory one?
Yeah, I just read over v3 again and it looks good to me. Thanks, Daniel!
-Peff
Contributing this tiny patch was a rewarding experience, getting to
know Git more intimately and collaborating with you all. Thanks so
much!
Kindly,
Daniel