Re: [PATCH v8 4/5] rebase -i: support --ignore-date

Phillip Wood [off-list ref] writes:

quoted

+# Checking for +0000 in the author date is sufficient since the
+# default timezone is UTC but the timezone used while committing is
+# +0530. The inverted logic in the grep is necessary to check all the
+# author dates in the file.
+test_ctime_is_ignored () {
+	git log $1 --format=%ai >authortime &&
+	! grep -v +0000 authortime
+}

I don't know what I was thinking when I wrote that - it should be called
test_atime_is_ignored() as it's testing the author date

Will tweak locally.  No need to resend.

Thanks.

On 19/08/2020 23:20, Junio C Hamano wrote:

Phillip Wood [off-list ref] writes:

quoted

quoted

+# Checking for +0000 in the author date is sufficient since the
+# default timezone is UTC but the timezone used while committing is
+# +0530. The inverted logic in the grep is necessary to check all the
+# author dates in the file.
+test_ctime_is_ignored () {
+	git log $1 --format=%ai >authortime &&
+	! grep -v +0000 authortime
+}

I don't know what I was thinking when I wrote that - it should be called
test_atime_is_ignored() as it's testing the author date

Will tweak locally.  No need to resend.

Thanks for doing that

Best wishes

Phillip

Thanks.