[PATCH] Documentation/git-send-email.txt: Mention less secure app access might need to enable.

Looks like Google changed gmail security and now less secure app access
needs to be explicitly enabled if 2-factor authentication is not in
place, otherwise send-mail fails with:

  5.7.8 Username and Password not accepted. Learn more at
  5.7.8  https://support.google.com/mail/?p=BadCredentials v5sm13756502ede.13 - gsmtp
---
 Documentation/git-send-email.txt | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/Documentation/git-send-email.txt b/Documentation/git-send-email.txt
index 0a69810147..5aed3f5b1d 100644
--- a/Documentation/git-send-email.txt
+++ b/Documentation/git-send-email.txt

@@ -494,6 +494,10 @@ edit ~/.gitconfig to specify your account settings:
 	smtpServerPort = 587
 ----
 
+If you do not have multifactor authentication setup on your gmail account, you
+need to allow less secure app access. Visit
+https://myaccount.google.com/lesssecureapps to enable it.
+
 If you have multifactor authentication setup on your gmail account, you will
 need to generate an app-specific password for use with 'git send-email'. Visit
 https://security.google.com/settings/security/apppasswords to create it.

@@ -505,7 +509,7 @@ following commands:
 	$ edit outgoing/0000-*
 	$ git send-email outgoing/*
 
-The first time you run it, you will be prompted for your credentials.  Enter the
+The first time you run it, you will be prompted for your credentials. Enter the
 app-specific or your regular password as appropriate.  If you have credential
 helper configured (see linkgit:git-credential[1]), the password will be saved in
 the credential store so you won't have to type it the next time.

-- 
2.23.0

On Mon, Aug 17, 2020 at 8:54 AM Vasyl Vavrychuk [off-list ref] wrote:

Looks like Google changed gmail security and now less secure app access
needs to be explicitly enabled if 2-factor authentication is not in
place, otherwise send-mail fails with:

  5.7.8 Username and Password not accepted. Learn more at
  5.7.8  https://support.google.com/mail/?p=BadCredentials v5sm13756502ede.13 - gsmtp
---

Missing sign-off. Please see Documentation/SubmittingPatches.

Thanks. Make sense. A few comments:

I think multi-factor is usually hyphenated, so perhaps:
s/multifactor/multi-factor/

Since you are not using it as a noun: s/setup/set up/

Also, Gmail is normally capitalized, so: s/gmail/Gmail

This unnecessary whitespace change just adds noise to the patch, thus
should be dropped.

Looks like Google changed Gmail security and now less secure app access
needs to be explicitly enabled if 2-factor authentication is not in
place, otherwise send-mail fails with:

  5.7.8 Username and Password not accepted. Learn more at
  5.7.8  https://support.google.com/mail/?p=BadCredentials v5sm13756502ede.13 - gsmtp

Signed-off-by: Vasyl Vavrychuk <redacted>
---
 Documentation/git-send-email.txt | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/Documentation/git-send-email.txt b/Documentation/git-send-email.txt
index 0a69810147..06953fd1e0 100644
--- a/Documentation/git-send-email.txt
+++ b/Documentation/git-send-email.txt

@@ -494,7 +494,11 @@ edit ~/.gitconfig to specify your account settings:
 	smtpServerPort = 587
 ----
 
-If you have multifactor authentication setup on your gmail account, you will
+If you do not have multi-factor authentication set up on your Gmail account, you
+will need to allow less secure app access. Visit
+https://myaccount.google.com/lesssecureapps to enable it.
+
+If you have multi-factor authentication set up on your Gmail account, you will
 need to generate an app-specific password for use with 'git send-email'. Visit
 https://security.google.com/settings/security/apppasswords to create it.
 

-- 
2.23.0

Google may have changed Gmail security and now less secure app access
needs to be explicitly enabled if two-factor authentication is not in
place, otherwise send-email fails with:

	5.7.8 Username and Password not accepted. Learn more at
	5.7.8  https://support.google.com/mail/?p=BadCredentials

Document steps required to make this work.

Original-patch-by: Vasyl Vavrychuk [off-list ref]
Signed-off-by: Denton Liu <redacted>
---
Range-diff against v2:
1:  2bcfd1403f < -:  ---------- Documentation/git-send-email.txt: Mention less secure app access might need to enable.
-:  ---------- > 1:  274475559a git-send-email.txt: mention less secure app access with Gmail

 Documentation/git-send-email.txt | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/Documentation/git-send-email.txt b/Documentation/git-send-email.txt
index 0a69810147..0db0783f2f 100644
--- a/Documentation/git-send-email.txt
+++ b/Documentation/git-send-email.txt

@@ -494,10 +494,14 @@ edit ~/.gitconfig to specify your account settings:
 	smtpServerPort = 587
 ----
 
-If you have multifactor authentication setup on your gmail account, you will
+If you have multi-factor authentication set up on your Gmail account, you will
 need to generate an app-specific password for use with 'git send-email'. Visit
 https://security.google.com/settings/security/apppasswords to create it.
 
+If you do not have multi-factor authentication set up on your Gmail account,
+you will need to allow less secure app access. Visit
+https://myaccount.google.com/lesssecureapps to enable it.
+
 Once your commits are ready to be sent to the mailing list, run the
 following commands:
 

-- 
2.30.0

On Thu, Jan 7, 2021 at 6:12 AM Denton Liu [off-list ref] wrote:

Google may have changed Gmail security and now less secure app access
needs to be explicitly enabled if two-factor authentication is not in
place, otherwise send-email fails with:

        5.7.8 Username and Password not accepted. Learn more at
        5.7.8  https://support.google.com/mail/?p=BadCredentials

Document steps required to make this work.

Original-patch-by: Vasyl Vavrychuk [off-list ref]
Signed-off-by: Denton Liu <redacted>

Thanks for picking this up.

Has this version changed in any substantial way from Vasyl's v2[1]? If
not, perhaps it makes sense to retain his authorship and sign-off.

[1]: https://lore.kernel.org/git/20200829153920.17155-1-vvavrychuk@gmail.com/