Re: [PATCH v2 0/7] making log --first-parent imply -m

From: Sergey Organov <hidden>
Date: 2020-08-04 21:58:07

Jeff King [off-list ref] writes:

On Tue, Aug 04, 2020 at 08:50:16PM +0300, Sergey Organov wrote:

[...]

quoted

+		} else {
+			die("--diff-merges: unknown value '%s'.", optarg);
+		}

A few nits:

I missed this the first time, sorry!

  - we usually don't have a period at the end of our error messages

Oops, I got the dot from

  die("--unpacked=<packfile> no longer supported.");

in the same file. Will fix.

  - this should probably be marked for translation, i.e.,
    die(_("translated message"), optarg)

OK, will do.

  - I think other similar messages are more like:

      unknown value for --diff-merges: %s

Thanks, I'll change wording to this one.

-- Sergey

From: Jeff King <hidden>
Date: 2020-08-04 22:08:35

On Wed, Aug 05, 2020 at 12:58:03AM +0300, Sergey Organov wrote:

quoted

  - we usually don't have a period at the end of our error messages

Oops, I got the dot from

  die("--unpacked=<packfile> no longer supported.");

in the same file. Will fix.

Yeah, there are a few that have snuck in. I wouldn't be opposed to a
patch to fix that one. :)

-Peff